Skip to content

Commit 6fa7919

Browse files
MAGE-186 Integration Test fix
1 parent 221bc8b commit 6fa7919

File tree

8 files changed

+39
-7
lines changed

8 files changed

+39
-7
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?php
2+
3+
namespace Algolia\AlgoliaSearch\Test\Integration\AssertValues;
4+
5+
class Magento244
6+
{
7+
public $productsOnStockCount = 180;
8+
public $productsOutOfStockCount = 183;
9+
public $lastJobDataSize = 13;
10+
public $expectedCategory = 17;
11+
public $attributesForFaceting = 5;
12+
public $automaticalSetOfCategoryAttributesForFaceting = 4;
13+
public $expectedPages = 9;
14+
public $expectedExcludePages = 7;
15+
}

Test/Integration/AssertValues/Magento_2_01.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,9 @@ class Magento_2_01
77
public $productsOnStockCount = 185;
88
public $productsOutOfStockCount = 186;
99
public $lastJobDataSize = 49;
10+
public $expectedCategory = 18;
11+
public $attributesForFaceting = 4;
12+
public $automaticalSetOfCategoryAttributesForFaceting = 3;
13+
public $expectedPages = 6;
14+
public $expectedExcludePages = 4;
1015
}

Test/Integration/AssertValues/Magento_2_2.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,9 @@ class Magento_2_2
77
public $productsOnStockCount = 186;
88
public $productsOutOfStockCount = 187;
99
public $lastJobDataSize = 14;
10+
public $expectedCategory= 18;
11+
public $attributesForFaceting = 4;
12+
public $automaticalSetOfCategoryAttributesForFaceting = 3;
13+
public $expectedPages = 6;
14+
public $expectedExcludePages = 4;
1015
}

Test/Integration/AssertValues/Magento_2_3.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,9 @@ class Magento_2_3
77
public $productsOnStockCount = 186;
88
public $productsOutOfStockCount = 187;
99
public $lastJobDataSize = 13;
10+
public $expectedCategory = 18;
11+
public $attributesForFaceting = 4;
12+
public $automaticalSetOfCategoryAttributesForFaceting = 3;
13+
public $expectedPages = 6;
14+
public $expectedExcludePages = 4;
1015
}

Test/Integration/CategoriesIndexingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public function testCategories()
1010
{
1111
/** @var Category $categoriesIndexer */
1212
$categoriesIndexer = $this->getObjectManager()->create(Category::class);
13-
$this->processTest($categoriesIndexer, 'categories', 18);
13+
$this->processTest($categoriesIndexer, 'categories', $this->assertValues->expectedCategory);
1414
}
1515

1616
public function testDefaultIndexableAttributes()

Test/Integration/ConfigTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function testFacets()
1717

1818
$indexSettings = $this->algoliaHelper->getIndex($this->indexPrefix . 'default_products')->getSettings();
1919

20-
$this->assertEquals(4, count($indexSettings['attributesForFaceting']));
20+
$this->assertEquals($this->assertValues->attributesForFaceting, count($indexSettings['attributesForFaceting']));
2121
}
2222

2323
public function testQueryRules()
@@ -77,7 +77,7 @@ public function testAutomaticalSetOfCategoriesFacet()
7777

7878
$indexSettings = $this->algoliaHelper->getIndex($this->indexPrefix . 'default_products')->getSettings();
7979

80-
$this->assertEquals(3, count($indexSettings['attributesForFaceting']));
80+
$this->assertEquals($this->assertValues->automaticalSetOfCategoryAttributesForFaceting, count($indexSettings['attributesForFaceting']));
8181

8282
$categoriesAttributeIsIncluded = false;
8383
foreach ($indexSettings['attributesForFaceting'] as $attribute) {
@@ -99,7 +99,7 @@ public function testAutomaticalSetOfCategoriesFacet()
9999

100100
$indexSettings = $this->algoliaHelper->getIndex($this->indexPrefix . 'default_products')->getSettings();
101101

102-
$this->assertEquals(3 + 1, count($indexSettings['attributesForFaceting']));
102+
$this->assertEquals($this->assertValues->automaticalSetOfCategoryAttributesForFaceting + 1, count($indexSettings['attributesForFaceting']));
103103

104104
$categoriesAttributeIsIncluded = false;
105105
foreach ($indexSettings['attributesForFaceting'] as $attribute) {

Test/Integration/PagesIndexingTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function testOnlyOnStockProducts()
1818
/** @var Page $indexer */
1919
$indexer = $this->getObjectManager()->create(Page::class);
2020

21-
$this->processTest($indexer, 'pages', 6);
21+
$this->processTest($indexer, 'pages', $this->assertValues->expectedPages);
2222
}
2323

2424
public function testExcludedPages()
@@ -34,7 +34,7 @@ public function testExcludedPages()
3434

3535
/** @var Page $indexer */
3636
$indexer = $this->getObjectManager()->create(Page::class);
37-
$this->processTest($indexer, 'pages', 4);
37+
$this->processTest($indexer, 'pages', $this->assertValues->expectedExcludePages);
3838

3939
$results = $this->algoliaHelper->query($this->indexPrefix . 'default_pages', '', []);
4040

Test/Integration/TestCase.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,10 @@ private function bootstrap()
105105
$this->assertValues = new Magento_2_01();
106106
} elseif (version_compare($this->getMagentoVersion(), '2.3.0', '<')) {
107107
$this->assertValues = new Magento_2_2();
108-
} else {
108+
} elseif (version_compare($this->getMagentoVersion(), '2.4.3', '<=')) {
109109
$this->assertValues = new Magento_2_3();
110+
} else {
111+
$this->assertValues = new Magento244();
110112
}
111113

112114
$this->algoliaHelper = $this->getObjectManager()->create(AlgoliaHelper::class);

0 commit comments

Comments
 (0)