MAGE-1122 Adjust profiling for exception based control flow

cammonro · cammonro · commit 731132cf8688 · 2024-12-18T17:13:52.000-05:00
diff --git a/Helper/Entity/ProductHelper.php b/Helper/Entity/ProductHelper.php
@@ -1313,7 +1313,6 @@ protected function clearFacetsQueryRules($indexName): void
      */
     public function canProductBeReindexed($product, $storeId, $isChildProduct = false)
     {
-        $this->logger->startProfiling(__METHOD__);
         if ($product->isDeleted() === true) {
             throw (new ProductDeletedException())
                 ->withProduct($product)
@@ -1347,7 +1346,6 @@ public function canProductBeReindexed($product, $storeId, $isChildProduct = fals
                 ->withStoreId($storeId);
         }
 
-        $this->logger->stopProfiling(__METHOD__);
         return true;
     }
 
diff --git a/Service/Product/IndexBuilder.php b/Service/Product/IndexBuilder.php
@@ -327,10 +327,13 @@ protected function getProductsRecords($storeId, $collection, $potentiallyDeleted
             }
 
             try {
+                $this->logger->startProfiling("canProductBeReindexed");
                 $this->productHelper->canProductBeReindexed($product, $storeId);
             } catch (ProductReindexingException $e) {
                 $productsToRemove[$productId] = $productId;
                 continue;
+            } finally {
+                $this->logger->stopProfiling("canProductBeReindexed");
             }
 
             if (isset($salesData[$productId])) {

Original file line number	Diff line number	Diff line change
`@@ -1313,7 +1313,6 @@ protected function clearFacetsQueryRules($indexName): void`
`1313`	`1313`	`*/`
`1314`	`1314`	`public function canProductBeReindexed($product, $storeId, $isChildProduct = false)`
`1315`	`1315`	`{`
`1316`		`- $this->logger->startProfiling(__METHOD__);`
`1317`	`1316`	`if ($product->isDeleted() === true) {`
`1318`	`1317`	`throw (new ProductDeletedException())`
`1319`	`1318`	`->withProduct($product)`
`@@ -1347,7 +1346,6 @@ public function canProductBeReindexed($product, $storeId, $isChildProduct = fals`
`1347`	`1346`	`->withStoreId($storeId);`
`1348`	`1347`	`}`
`1349`	`1348`
`1350`		`- $this->logger->stopProfiling(__METHOD__);`
`1351`	`1349`	`return true;`
`1352`	`1350`	`}`
`1353`	`1351`
Original file line number	Diff line number	Diff line change
`@@ -327,10 +327,13 @@ protected function getProductsRecords($storeId, $collection, $potentiallyDeleted`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`try {`
	`330`	`+ $this->logger->startProfiling("canProductBeReindexed");`
`330`	`331`	`$this->productHelper->canProductBeReindexed($product, $storeId);`
`331`	`332`	`} catch (ProductReindexingException $e) {`
`332`	`333`	`$productsToRemove[$productId] = $productId;`
`333`	`334`	`continue;`
	`335`	`+ } finally {`
	`336`	`+ $this->logger->stopProfiling("canProductBeReindexed");`
`334`	`337`	`}`
`335`	`338`
`336`	`339`	`if (isset($salesData[$productId])) {`