MAGE-721 Remove tmp index replica operations as they are incompatible with index move ops

Author: cammonro

Helper/ConfigHelper.php

@@ -1016,6 +1016,7 @@ protected function isGroupPricingExcludedFromWebsite(int $customerGroupId, int $
     /**
      * Augment sorting configuration with corresponding replica indices, ranking,
      * and (as needed) customer group pricing
+     * TODO: MAGE-941 Remove the $originalIndexName param - this should never be needed as tmp indices cannot have attached replicas
      *
      * @param string $originalIndexName
      * @param ?int $storeId

Helper/Entity/ProductHelper.php

@@ -373,18 +373,14 @@ public function setSettings(string $indexName, string $indexNameTmp, int $storeI
         }
 
         $this->replicaManager->handleReplicas($indexName, $storeId, $indexSettings);
-        // TODO: Reevaluate whether we need to pre-bake the temp index replicas
-        if ($saveToTmpIndicesToo) {
-            $this->replicaManager->handleReplicas($indexNameTmp, $storeId, $indexSettings);
-        }
 
         if ($saveToTmpIndicesToo) {
             try {
                 $this->algoliaHelper->copySynonyms($indexName, $indexNameTmp);
                 $this->algoliaHelper->waitLastTask();
                 $this->logger->log('
-                    Copying synonyms from production index to "' . $indexNameTmp . '" to not erase them with the index move.
-                ');
+                        Copying synonyms from production index to "' . $indexNameTmp . '" to not erase them with the index move.
+                    ');
             } catch (AlgoliaException $e) {
                 $this->logger->error('Error encountered while copying synonyms: ' . $e->getMessage());
             }
@@ -393,8 +389,8 @@ public function setSettings(string $indexName, string $indexNameTmp, int $storeI
                 $this->algoliaHelper->copyQueryRules($indexName, $indexNameTmp);
                 $this->algoliaHelper->waitLastTask();
                 $this->logger->log('
-                    Copying query rules from production index to "' . $indexNameTmp . '" to not erase them with the index move.
-                ');
+                        Copying query rules from production index to "' . $indexNameTmp . '" to not erase them with the index move.
+                    ');
             } catch (AlgoliaException $e) {
                 if ($e->getCode() !== 404) {
                     throw $e;