Merge pull request #1656 from algolia/fix/MAGE-1153-duplicate-synonyms

damcou · web-flow · commit 7d9926e600d5 · 2024-12-06T16:52:58.000+01:00
MAGE-1153: fix synonyms duplication after PHP v4 upgrade
diff --git a/Helper/AlgoliaHelper.php b/Helper/AlgoliaHelper.php
@@ -371,7 +371,7 @@ public function mergeSettings($indexName, $settings, string $mergeSettingsFrom =
         } catch (Exception $e) {
         }
 
-        $removes = ['slaves', 'replicas', 'decompoundedAttributes'];
+        $removes = ['slaves', 'replicas', 'decompoundedAttributes', 'synonyms'];
 
         if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {
             $removes[] = 'mode';

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ public function mergeSettings($indexName, $settings, string $mergeSettingsFrom =`
`371`	`371`	`} catch (Exception $e) {`
`372`	`372`	`}`
`373`	`373`
`374`		`- $removes = ['slaves', 'replicas', 'decompoundedAttributes'];`
	`374`	`+ $removes = ['slaves', 'replicas', 'decompoundedAttributes', 'synonyms'];`
`375`	`375`
`376`	`376`	`if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {`
`377`	`377`	`$removes[] = 'mode';`