Skip to content

Commit 84069b4

Browse files
authored
Merge pull request #1367 from algolia/integration/3.10.4
Integration Test 3.10.4
2 parents 18a8021 + ae5a3b2 commit 84069b4

File tree

11 files changed

+51
-13
lines changed

11 files changed

+51
-13
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
# CHANGE LOG
22

3+
## 3.10.4
4+
5+
### Bug Fixes
6+
- Fixed the checkout console “tagName” error due to autocomplete not defined by ensuring proper loading of the js library
7+
- Fixed the undefined config variable issue in recommend
8+
- Fixed the issue with logged in user token for click and conversion when personification is turned off.
9+
- Fixed the issue with Items click position for Recommend Events
10+
- Fixed the issue with Hyphen converted to slash in facets.
11+
12+
313
## 3.10.3
414

515
### UPDATES

Observer/Insights/CustomerLogin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function execute(Observer $observer)
3131
/** @var Customer $customer */
3232
$customer = $observer->getEvent()->getCustomer();
3333

34-
if ($this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {
34+
if ($this->insightsHelper->getConfigHelper()->isClickConversionAnalyticsEnabled($customer->getStoreId()) || $this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {
3535
$this->insightsHelper->setUserToken($customer);
3636
}
3737
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Algolia Search for Magento 2
22
============================
33

4-
![Latest version](https://img.shields.io/badge/latest-3.10.3-green)
4+
![Latest version](https://img.shields.io/badge/latest-3.10.4-green)
55
![Magento 2](https://img.shields.io/badge/Magento-2.4.x-orange)
66

77
![PHP](https://img.shields.io/badge/PHP-8.2%2C8.1%2C7.4-blue)

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Algolia Search integration for Magento 2",
44
"type": "magento2-module",
55
"license": ["MIT"],
6-
"version": "3.10.3",
6+
"version": "3.10.4",
77
"require": {
88
"magento/framework": "~102.0|~103.0",
99
"algolia/algoliasearch-client-php": "3.2",

etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Algolia_AlgoliaSearch" setup_version="3.10.3">
3+
<module name="Algolia_AlgoliaSearch" setup_version="3.10.4">
44
<sequence>
55
<module name="Magento_Theme"/>
66
<module name="Magento_Backend"/>

view/frontend/requirejs-config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ var config = {
2727
'rangeSlider' : 'Algolia_AlgoliaSearch/navigation/range-slider-widget',
2828
},
2929
deps : [
30-
'algoliaAutocomplete',
3130
'algoliaInstantSearch',
3231
'algoliaInsights'
3332
],

view/frontend/templates/autocomplete.phtml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,12 @@ $catalogSearchHelper = $blockInstance->getCatalogSearchHelper();
77

88
// Render form with autocomplete input
99
if ($config->isAutoCompleteEnabled()) : ?>
10+
<script type="text/x-magento-init">
11+
{
12+
"*": {
13+
"algoliaAutocomplete": {}
14+
}
15+
}
16+
</script>
1017
<div id="algoliaAutocomplete" class="block block-search algolia-search-block algolia-search-input"></div>
1118
<?php endif;?>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<script type="text/template" id="refinements-lists-item-template">
22
<label class="{{cssClasses.label}} {{#isRefined}}checked{{/isRefined}}">
33
<input class="{{cssClasses.checkbox}}" {{#isRefined}}checked{{/isRefined}} type="checkbox" value="{{value}}" />
4-
{{value}}
4+
{{label}}
55
<span class="{{cssClasses.count}}">{{count}}</span>
66
</label>
7-
</script>
7+
</script>

view/frontend/web/insights.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,7 @@ define(
150150
var eventData = self.buildEventData(
151151
event.eventName,
152152
$this.data('objectid'),
153-
$this.data('indexname') ? $this.data('indexname') : self.defaultIndexName,
154-
$this.data('position')
153+
$this.data('indexname') ? $this.data('indexname') : self.defaultIndexName
155154
);
156155

157156
self.trackClick(eventData);

view/frontend/web/internals/template/recommend/products.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@ define([], function () {
44
let correctFKey = getCookie('form_key');
55
let action = algoliaConfig.recommend.addToCartParams.action + 'product/' + item.objectID + '/';
66
if(correctFKey != "" && algoliaConfig.recommend.addToCartParams.formKey != correctFKey) {
7-
config.recommend.addToCartParams.formKey = correctFKey;
7+
algoliaConfig.recommend.addToCartParams.formKey = correctFKey;
88
}
9-
this.config = algoliaConfig;
109
this.defaultIndexName = algoliaConfig.indexName + '_products';
1110
return html`<div class="product-details">
12-
<a class="recommend-item product-url" href="${item.url}" data-objectid=${item.objectID} data-index=${this.defaultIndexName}>
11+
<a class="recommend-item product-url" href="${item.url}" data-objectid=${item.objectID} data-position=${item.position} data-index=${this.defaultIndexName}>
1312
<img class="product-img" src="${item.image_url}" alt="${item.name}"/>
1413
<p class="product-name">${item.name}</p>
1514
${addTocart && html`

0 commit comments

Comments
 (0)