MAGE-838 Add distinct method for replica sync enablement

Author: cammonro

Api/Product/ReplicaManagerInterface.php

@@ -31,4 +31,13 @@ interface ReplicaManagerInterface
      * @throws NoSuchEntityException
      */
     public function handleReplicas(string $primaryIndexName, int $storeId, array $primaryIndexSettings): void;
+
+
+    /**
+     * For standard Magento front end (e.g. Luma) replicas will likely only be needed if InstantSearch is enabled
+     * Headless implementations may wish to override this behavior via plugin
+     * @param int $storeId
+     * @return bool
+     */
+    public function isReplicaSyncEnabled(int $storeId): bool;
 }

Model/Product/ReplicaManager.php

@@ -210,8 +210,7 @@ protected function getMagentoReplicaSettingsFromConfig(string $primaryIndexName,
      */
     public function handleReplicas(string $primaryIndexName, int $storeId, array $primaryIndexSettings): void
     {
-        // TODO: InstantSearch enablement should not be a hard requirement (i.e. headless implementations may still need replicas) - add an override for this
-        if ($this->configHelper->isInstantEnabled($storeId)
+        if ($this->isReplicaSyncEnabled($storeId)
             && $this->hasReplicaConfigurationChanged($primaryIndexName, $storeId)
             && $this->isReplicaConfigurationValid($primaryIndexName, $storeId)) {
             $addedReplicas = $this->setReplicasOnPrimaryIndex($primaryIndexName, $storeId);
@@ -363,4 +362,12 @@ function($replica) use ($replicas) {
             }
         }
     }
+
+    /**
+     * @inheritDoc
+     */
+    public function isReplicaSyncEnabled(int $storeId): bool
+    {
+        return $this->configHelper->isInstantEnabled($storeId);
+    }
 }