MAGE-891: remove non authenticated user token renewal

Author: damcou

Helper/InsightsHelper.php

@@ -28,9 +28,6 @@ class InsightsHelper
     /** @var int */
     public const ALGOLIA_USER_TOKEN_MAX_LENGTH = 64;
 
-    /** @var int */
-    public const ALGOLIA_USER_TOKEN_DEFAULT_LIFETIME = 15768000; // 6 months
-
     /** @var string */
     public const QUOTE_ITEM_QUERY_PARAM = 'algoliasearch_query_param';
 
@@ -160,30 +157,6 @@ public function setAuthenticatedUserToken(Customer $customer): string|null
         return $userToken;
     }
 
-    /**
-     * Sets a token for a non-authenticated user
-     *
-     * @return void
-     */
-    public function setNonAuthenticatedUserToken(): void
-    {
-        $metaData = $this->cookieMetadataFactory->createPublicCookieMetadata()
-            ->setDuration(InsightsHelper::ALGOLIA_USER_TOKEN_DEFAULT_LIFETIME)
-            ->setPath('/')
-            ->setHttpOnly(false)
-            ->setSecure(false);
-
-        try {
-            $this->cookieManager->setPublicCookie(
-                InsightsHelper::ALGOLIA_ANON_USER_TOKEN_COOKIE_NAME,
-                (string) $this->cookieManager->getCookie(InsightsHelper::ALGOLIA_ANON_USER_TOKEN_COOKIE_NAME),
-                $metaData
-            );
-        } catch (LocalizedException $e) {
-            $this->logger->error("Error writing anonymous user cookie: " . $e->getMessage());
-        }
-    }
-
     /**
      * @param int|null $storeId
      * @return bool

Observer/Insights/CookieRefresherObserver.php

@@ -32,8 +32,6 @@ public function execute(Observer $observer): void
     {
         if ($this->customerSession->isLoggedIn()) {
             $this->insightsHelper->setAuthenticatedUserToken($this->customerSession->getCustomer());
-        } else {
-            $this->insightsHelper->setNonAuthenticatedUserToken();
         }
     }
 }

Observer/Insights/CustomerLogout.php

@@ -47,6 +47,7 @@ public function execute(\Magento\Framework\Event\Observer $observer): void
             try {
                 $this->cookieManager->setPublicCookie(self::UNSET_AUTHENTICATION_USER_TOKEN_COOKIE_NAME, 1, $metaDataUnset);
                 $this->cookieManager->deleteCookie(InsightsHelper::ALGOLIA_CUSTOMER_USER_TOKEN_COOKIE_NAME, $metadata);
+                $this->cookieManager->deleteCookie(InsightsHelper::ALGOLIA_ANON_USER_TOKEN_COOKIE_NAME, $metadata);
             } catch (LocalizedException $e) {
                 $this->logger->error("Error writing Algolia customer cookies: " . $e->getMessage());
             }