MAGE-1131: Added some additional integration tests for legacy indexers

Author: damcou

Test/Integration/Indexing/Category/CategoriesIndexingTest.php

@@ -3,6 +3,7 @@
 namespace Algolia\AlgoliaSearch\Test\Integration\Indexing\Category;
 
 use Algolia\AlgoliaSearch\Console\Command\Indexer\IndexCategoriesCommand;
+use Algolia\AlgoliaSearch\Model\Indexer\Category as CategoryIndexer;
 use Algolia\AlgoliaSearch\Service\Category\BatchQueueProcessor as CategoryBatchQueueProcessor;
 use Algolia\AlgoliaSearch\Test\Integration\Indexing\IndexingTestCase;
 
@@ -59,4 +60,22 @@ public function testIndexingCategoriesCommand()
         $indexCategoriesCmd = $this->objectManager->get(IndexCategoriesCommand::class);
         $this->processCommandTest($indexCategoriesCmd,'categories', $this->assertValues->expectedCategory);
     }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/categories 0
+     */
+    public function testDisabledOldIndexer()
+    {
+        $categoriesIndexer = $this->objectManager->create(CategoryIndexer::class);
+        $this->processOldIndexerTest($categoriesIndexer, 'categories', 0);
+    }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/categories 1
+     */
+    public function testEnabledOldIndexer()
+    {
+        $categoriesIndexer = $this->objectManager->create(CategoryIndexer::class);
+        $this->processOldIndexerTest($categoriesIndexer, 'categories', $this->assertValues->expectedCategory);
+    }
 }

Test/Integration/Indexing/IndexingTestCase.php

@@ -6,6 +6,7 @@
 use Algolia\AlgoliaSearch\Console\Command\Indexer\AbstractIndexerCommand;
 use Algolia\AlgoliaSearch\Exceptions\AlgoliaException;
 use Algolia\AlgoliaSearch\Test\Integration\TestCase;
+use Magento\Framework\Indexer\ActionInterface;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
@@ -31,6 +32,16 @@ protected function processTest(
         $this->assertNumberofHits($indexSuffix, $expectedNbHits);
     }
 
+    protected function processOldIndexerTest(ActionInterface $indexer, $indexSuffix, $expectedNbHits)
+    {
+        $this->algoliaHelper->clearIndex($this->indexPrefix . 'default_' . $indexSuffix);
+
+        $indexer->executeFull();
+        $this->algoliaHelper->waitLastTask();
+
+        $this->assertNumberofHits($indexSuffix, $expectedNbHits);
+    }
+
     protected function processCommandTest(
         AbstractIndexerCommand $command,
         $indexSuffix,

Test/Integration/Indexing/Page/PagesIndexingTest.php

@@ -4,6 +4,7 @@
 
 use Algolia\AlgoliaSearch\Console\Command\Indexer\IndexPagesCommand;
 use Algolia\AlgoliaSearch\Helper\Entity\PageHelper;
+use Algolia\AlgoliaSearch\Model\Indexer\Page as PageIndexer;
 use Algolia\AlgoliaSearch\Service\Page\BatchQueueProcessor as PageBatchQueueProcessor;
 use Algolia\AlgoliaSearch\Test\Integration\Indexing\IndexingTestCase;
 use Magento\Cms\Model\PageFactory;
@@ -159,4 +160,27 @@ public function testIndexingPagesCommand()
         $indexPagesCmd = $this->objectManager->get(IndexPagesCommand::class);
         $this->processCommandTest($indexPagesCmd, 'pages', $this->assertValues->expectedPages);
     }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/pages 0
+     */
+    public function testDisabledOldIndexer()
+    {
+        $pagesIndexer = $this->objectManager->create(PageIndexer::class);
+        $this->processOldIndexerTest($pagesIndexer, 'pages', 0);
+    }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/pages 1
+     */
+    public function testEnabledOldIndexer()
+    {
+        $this->setConfig(
+            'algoliasearch_autocomplete/autocomplete/excluded_pages',
+            $this->getSerializer()->serialize([])
+        );
+
+        $pagesIndexer = $this->objectManager->create(PageIndexer::class);
+        $this->processOldIndexerTest($pagesIndexer, 'pages', $this->assertValues->expectedPages);
+    }
 }

Test/Integration/Indexing/Product/ProductsIndexingTest.php

@@ -6,6 +6,7 @@
 use Algolia\AlgoliaSearch\Exceptions\AlgoliaException;
 use Algolia\AlgoliaSearch\Exceptions\ExceededRetriesException;
 use Algolia\AlgoliaSearch\Helper\ConfigHelper;
+use Algolia\AlgoliaSearch\Model\Indexer\Product as ProductIndexer;
 use Magento\Catalog\Model\Product;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Indexer\IndexerRegistry;
@@ -97,6 +98,28 @@ public function testIndexingProductsCommand()
         $this->processCommandTest($indexProductsCmd, 'products', $this->assertValues->productsOnStockCount);
     }
 
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/products 0
+     */
+    public function testDisabledOldIndexer()
+    {
+        $productsIndexer = $this->objectManager->create(ProductIndexer::class);
+        $this->processOldIndexerTest($productsIndexer, 'products', 0);
+    }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_indexing_manager/full_indexing/products 1
+     */
+    public function testEnabledOldIndexer()
+    {
+        $this->setConfig(ConfigHelper::SHOW_OUT_OF_STOCK, 0);
+
+        $this->updateStockItem(self::OUT_OF_STOCK_PRODUCT_SKU, false);
+
+        $productsIndexer = $this->objectManager->create(ProductIndexer::class);
+        $this->processOldIndexerTest($productsIndexer, 'products', $this->assertValues->productsOnStockCount);
+    }
+
     private function getValidTestProduct()
     {
         if (!$this->testProductId) {