MAGE-1122 Add missing price handler service for delta index

Author: cammonro

Helper/Data.php

@@ -12,6 +12,7 @@
 use Algolia\AlgoliaSearch\Helper\Entity\ProductHelper;
 use Algolia\AlgoliaSearch\Helper\Entity\SuggestionHelper;
 use Algolia\AlgoliaSearch\Service\IndexNameFetcher;
+use Algolia\AlgoliaSearch\Service\Product\MissingPriceIndexHandler;
 use Magento\Catalog\Model\Category;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\ResourceModel\Product\Collection;
@@ -35,21 +36,22 @@ class Data
     protected IndexerInterface $priceIndexer;
 
     public function __construct(
-        protected AlgoliaHelper           $algoliaHelper,
-        protected ConfigHelper            $configHelper,
-        protected ProductHelper           $productHelper,
-        protected CategoryHelper          $categoryHelper,
-        protected PageHelper              $pageHelper,
-        protected SuggestionHelper        $suggestionHelper,
-        protected AdditionalSectionHelper $additionalSectionHelper,
-        protected Emulation               $emulation,
-        protected Logger                  $logger,
-        protected ResourceConnection      $resource,
-        protected ManagerInterface        $eventManager,
-        protected ScopeCodeResolver       $scopeCodeResolver,
-        protected StoreManagerInterface   $storeManager,
-        protected IndexNameFetcher        $indexNameFetcher,
-        IndexerRegistry                   $indexerRegistry
+        protected AlgoliaHelper            $algoliaHelper,
+        protected ConfigHelper             $configHelper,
+        protected ProductHelper            $productHelper,
+        protected CategoryHelper           $categoryHelper,
+        protected PageHelper               $pageHelper,
+        protected SuggestionHelper         $suggestionHelper,
+        protected AdditionalSectionHelper  $additionalSectionHelper,
+        protected Emulation                $emulation,
+        protected Logger                   $logger,
+        protected ResourceConnection       $resource,
+        protected ManagerInterface         $eventManager,
+        protected ScopeCodeResolver        $scopeCodeResolver,
+        protected StoreManagerInterface    $storeManager,
+        protected IndexNameFetcher         $indexNameFetcher,
+        protected MissingPriceIndexHandler $missingPriceIndexHandler,
+        IndexerRegistry                    $indexerRegistry
     )
     {
         $this->priceIndexer = $indexerRegistry->get('catalog_product_price');
@@ -78,7 +80,7 @@ public function deleteObjects(int $storeId, array $ids, string $indexName): void
         $this->algoliaHelper->deleteObjects($ids, $indexName);
     }
 
-    /**
+    /**`
      * @param string $query
      * @param int $storeId
      * @param array|null $searchParams
@@ -370,7 +372,7 @@ public function rebuildStoreProductIndex(int $storeId, array $productIds): void
             return;
         }
 
-        $this->checkPriceIndex($productIds);
+        $this->missingPriceIndexHandler->refreshPriceIndex($productIds);
 
         $this->startEmulation($storeId);
         $this->logger->start('Indexing');
@@ -936,18 +938,4 @@ protected function deleteInactiveIds($storeId, $objectIds, $indexName): void
         $idsToDeleteFromAlgolia = array_diff($objectIds, $dbIds);
         $this->algoliaHelper->deleteObjects($idsToDeleteFromAlgolia, $indexName);
     }
-
-    /**
-     * If the price index is stale
-     * @param array $productIds
-     * @return void
-     */
-    protected function checkPriceIndex(array $productIds): void
-    {
-        $state = $this->priceIndexer->getState()->getStatus();
-        if ($state === \Magento\Framework\Indexer\StateInterface::STATUS_INVALID) {
-            $this->priceIndexer->reindexList($productIds);
-        }
-    }
-
 }

Service/Product/MissingPriceIndexHandler.php

@@ -0,0 +1,63 @@
+<?php
+
+namespace Algolia\AlgoliaSearch\Service\Product;
+
+use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
+use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\Framework\Indexer\IndexerInterface;
+
+class MissingPriceIndexHandler
+{
+    protected IndexerInterface $indexer;
+    public function __construct(
+        protected CollectionFactory $productCollectionFactory,
+        IndexerRegistry $indexerRegistry
+    )
+    {
+        $this->indexer = $indexerRegistry->get('catalog_product_price');
+    }
+
+    /**
+     * @param array $productIds
+     * @return int[] Array of product IDs that were reindexed by this repair operation
+     */
+    public function refreshPriceIndex(array $productIds): array
+    {
+        $reindexIds = $this->getProductIdsToReindex($productIds);
+        if (empty($reindexIds)) {
+            return [];
+        }
+
+        $this->indexer->reindexList($reindexIds);
+
+        return $reindexIds;
+    }
+
+    /**
+     * @param int[] $productIds
+     * @return int[]
+     */
+    protected function getProductIdsToReindex(array $productIds): array
+    {
+        $state = $this->indexer->getState()->getStatus();
+        if ($state === \Magento\Framework\Indexer\StateInterface::STATUS_INVALID) {
+            return $productIds;
+        }
+
+        $collection = $this->productCollectionFactory->create();
+
+        $collection->addAttributeToSelect(['name', 'price']);
+
+        $collection->getSelect()->joinLeft(
+            ['price_index' => 'catalog_product_index_price'],
+            'e.entity_id = price_index.entity_id',
+            []
+        );
+
+        $collection->getSelect()
+            ->where('price_index.entity_id IS NULL')
+            ->where('entity_id IN (?)', $productIds);
+
+        return $collection->getAllIds();
+    }
+}