Merge pull request #1583 from algolia/bugfix/MAGE-928/insight-query-string

cammonro · web-flow · commit 9dca4d3d8dd5 · 2024-08-09T16:40:02.000-04:00
MAGE-928: Fix generated url for insights
diff --git a/view/frontend/web/js/autocomplete.js b/view/frontend/web/js/autocomplete.js
@@ -210,7 +210,7 @@ define([
                     indexName: hit.__autocomplete_indexName,
                 });
                 if (hit.url.indexOf('?') > -1) {
-                    hit.urlForInsights += insightsDataUrlString;
+                    hit.urlForInsights += '&' + insightsDataUrlString;
                 } else {
                     hit.urlForInsights += '?' + insightsDataUrlString;
                 }
diff --git a/view/frontend/web/js/internals/common.js b/view/frontend/web/js/internals/common.js
@@ -237,7 +237,7 @@ define(['jquery', 'algoliaBundle'], function ($, algoliaBundle) {
                     indexName: hit.__indexName
                 });
                 if (hit.url.indexOf('?') > -1) {
-                    hit.urlForInsights += insightsDataUrlString
+                    hit.urlForInsights += '&' + insightsDataUrlString;
                 } else {
                     hit.urlForInsights += '?' + insightsDataUrlString;
                 }

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ define([`
`210`	`210`	`indexName: hit.__autocomplete_indexName,`
`211`	`211`	`});`
`212`	`212`	`if (hit.url.indexOf('?') > -1) {`
`213`		`- hit.urlForInsights += insightsDataUrlString;`
	`213`	`+ hit.urlForInsights += '&' + insightsDataUrlString;`
`214`	`214`	`} else {`
`215`	`215`	`hit.urlForInsights += '?' + insightsDataUrlString;`
`216`	`216`	`}`
Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ define(['jquery', 'algoliaBundle'], function ($, algoliaBundle) {`
`237`	`237`	`indexName: hit.__indexName`
`238`	`238`	`});`
`239`	`239`	`if (hit.url.indexOf('?') > -1) {`
`240`		`- hit.urlForInsights += insightsDataUrlString`
	`240`	`+ hit.urlForInsights += '&' + insightsDataUrlString;`
`241`	`241`	`} else {`
`242`	`242`	`hit.urlForInsights += '?' + insightsDataUrlString;`
`243`	`243`	`}`