Merge pull request #1743 from algolia/fix/MAGE-1251-rebuild-replicas-3.15

cammonro · web-flow · commit a24f1c22fb86 · 2025-04-30T09:26:41.000-04:00
MAGE-1251 Update unit tests
diff --git a/Test/Unit/Service/ReplicaManagerTest.php b/Test/Unit/Service/ReplicaManagerTest.php
@@ -57,7 +57,9 @@ public function testVirtualReplicaSettingRemove(): void
 
         $newReplicas = $this->replicaManager->removeReplicaFromReplicaSetting($replicaSetting, $replicaToRemove);
 
-        $this->assertNotContains($replicaToRemove, $newReplicas);
+        $this->assertNotContains("virtual($replicaToRemove)", $newReplicas);
+        $this->assertContains('virtual(replica1)', $newReplicas);
+        $this->assertContains('virtual(replica3)', $newReplicas);
     }
 
     public function testStandardReplicaSettingRemove(): void
@@ -72,5 +74,8 @@ public function testStandardReplicaSettingRemove(): void
         $newReplicas = $this->replicaManager->removeReplicaFromReplicaSetting($replicaSetting, $replicaToRemove);
 
         $this->assertNotContains($replicaToRemove, $newReplicas);
+        $this->assertContains('replica1', $newReplicas);
+        $this->assertContains('replica3', $newReplicas);
+
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,9 @@ public function testVirtualReplicaSettingRemove(): void`
`57`	`57`
`58`	`58`	`$newReplicas = $this->replicaManager->removeReplicaFromReplicaSetting($replicaSetting, $replicaToRemove);`
`59`	`59`
`60`		`- $this->assertNotContains($replicaToRemove, $newReplicas);`
	`60`	`+ $this->assertNotContains("virtual($replicaToRemove)", $newReplicas);`
	`61`	`+ $this->assertContains('virtual(replica1)', $newReplicas);`
	`62`	`+ $this->assertContains('virtual(replica3)', $newReplicas);`
`61`	`63`	`}`
`62`	`64`
`63`	`65`	`public function testStandardReplicaSettingRemove(): void`
`@@ -72,5 +74,8 @@ public function testStandardReplicaSettingRemove(): void`
`72`	`74`	`$newReplicas = $this->replicaManager->removeReplicaFromReplicaSetting($replicaSetting, $replicaToRemove);`
`73`	`75`
`74`	`76`	`$this->assertNotContains($replicaToRemove, $newReplicas);`
	`77`	`+ $this->assertContains('replica1', $newReplicas);`
	`78`	`+ $this->assertContains('replica3', $newReplicas);`
	`79`	`+`
`75`	`80`	`}`
`76`	`81`	`}`