MAGE-941 Add nullable types

cammonro · cammonro · commit a337a4539009 · 2024-06-29T14:01:50.000-04:00
diff --git a/Service/IndexNameFetcher.php b/Service/IndexNameFetcher.php
@@ -24,7 +24,7 @@ public function __construct(
      * @return string
      * @throws NoSuchEntityException
      */
-    public function getIndexName(string $indexSuffix, int $storeId = null, bool $tmp = false): string
+    public function getIndexName(string $indexSuffix, ?int $storeId = null, bool $tmp = false): string
     {
         return $this->getBaseIndexName($storeId) . $indexSuffix . ($tmp ? self::INDEX_TEMP_SUFFIX : '');
     }
@@ -34,7 +34,7 @@ public function getIndexName(string $indexSuffix, int $storeId = null, bool $tmp
      * @return string
      * @throws NoSuchEntityException
      */
-    public function getBaseIndexName(int $storeId = null): string
+    public function getBaseIndexName(?int $storeId = null): string
     {
         return $this->configHelper->getIndexPrefix($storeId) . $this->storeManager->getStore($storeId)->getCode();
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function __construct(`
`24`	`24`	`* @return string`
`25`	`25`	`* @throws NoSuchEntityException`
`26`	`26`	`*/`
`27`		`- public function getIndexName(string $indexSuffix, int $storeId = null, bool $tmp = false): string`
	`27`	`+ public function getIndexName(string $indexSuffix, ?int $storeId = null, bool $tmp = false): string`
`28`	`28`	`{`
`29`	`29`	`return $this->getBaseIndexName($storeId) . $indexSuffix . ($tmp ? self::INDEX_TEMP_SUFFIX : '');`
`30`	`30`	`}`
`@@ -34,7 +34,7 @@ public function getIndexName(string $indexSuffix, int $storeId = null, bool $tmp`
`34`	`34`	`* @return string`
`35`	`35`	`* @throws NoSuchEntityException`
`36`	`36`	`*/`
`37`		`- public function getBaseIndexName(int $storeId = null): string`
	`37`	`+ public function getBaseIndexName(?int $storeId = null): string`
`38`	`38`	`{`
`39`	`39`	`return $this->configHelper->getIndexPrefix($storeId) . $this->storeManager->getStore($storeId)->getCode();`
`40`	`40`	`}`