Skip to content

Commit a43700c

Browse files
committed
MAGE-1113 Adjust help text per review
1 parent f347bd0 commit a43700c

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Console/Command/AbstractStoreCommand.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
abstract class AbstractStoreCommand extends Command
1717
{
18-
protected const STORE_ARGUMENT = 'store';
18+
protected const STORE_ARGUMENT = 'store_id';
1919

2020
protected ?OutputInterface $output = null;
2121
protected ?InputInterface $input = null;
@@ -63,8 +63,9 @@ protected function setAreaCode(): void
6363
{
6464
try {
6565
$this->state->setAreaCode(Area::AREA_CRONTAB);
66-
} catch (LocalizedException) {
67-
// Area code is already set - nothing to do
66+
} catch (LocalizedException $e) {
67+
// Area code is already set - nothing to do - but report regardless
68+
$this->output->writeln("Unable to set area code due to the following error: " . $e->getMessage());
6869
}
6970
}
7071

Console/Command/SynonymDeduplicateCommand.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ protected function getCommandName(): string
3737

3838
protected function getCommandDescription(): string
3939
{
40-
return "Identify and remove duplicate synonyms in Algolia";
40+
return "Identify and remove duplicate synonyms in Algolia for the following types: synonyms, placeholders and alternative corrections. \n <fg=red>WARNING:</fg=red> If you use one-way synonyms, do not use this command as it will remove these from your index.";
4141
}
4242

4343
protected function getStoreArgumentDescription(): string
4444
{
45-
return 'ID(s) for store(s) containing synonyms to deduplicate in Algolia (optional), if not specified, synonyms for all stores will be deduplicated';
45+
return 'ID(s) for store(s) containing synonyms to deduplicate in Algolia (optional), if not specified, synonyms for all stores will be deduplicated. Pass multiple store IDs as a list of integers separated by spaces. e.g.: bin/magento algolia:synonyms:deduplicate 1 2 3';
4646
}
4747

4848
protected function getAdditionalDefinition(): array
@@ -86,7 +86,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
8686
*/
8787
protected function confirmDedupeOperation(): bool
8888
{
89-
$this->output->writeln('<fg=red>This deduplicate process cannot handle one way synonyms and will remove them altogether!</fg=red>');
89+
$this->output->writeln('<fg=red>WARNING:</fg=red> This deduplicate process cannot handle one way synonyms and will remove them altogether!');
9090
return $this->confirmOperation();
9191
}
9292

0 commit comments

Comments
 (0)