MAGE-1138: add integration test

Author: damcou

Setup/Patch/Schema/ConfigPatch.php

@@ -68,6 +68,7 @@ class ConfigPatch implements SchemaPatchInterface
         'algoliasearch_queue/queue/active' => '0',
         'algoliasearch_queue/queue/number_of_job_to_run' => '5',
         'algoliasearch_queue/queue/number_of_retries' => '3',
+        'algoliasearch_queue/queue/use_tmp_index' => '1',
 
         'algoliasearch_cc_analytics/cc_analytics_group/enable' => '0',
         'algoliasearch_cc_analytics/cc_analytics_group/is_selector' => '.ais-Hits-item a.result, .ais-InfiniteHits-item a.result',

Test/Integration/Indexing/Queue/QueueTest.php

@@ -3,6 +3,7 @@
 namespace Algolia\AlgoliaSearch\Test\Integration\Indexing\Queue;
 
 use Algolia\AlgoliaSearch\Helper\ConfigHelper;
+use Algolia\AlgoliaSearch\Helper\Configuration\QueueHelper;
 use Algolia\AlgoliaSearch\Model\Indexer\QueueRunner;
 use Algolia\AlgoliaSearch\Model\IndicesConfigurator;
 use Algolia\AlgoliaSearch\Model\Job;
@@ -44,11 +45,11 @@ protected function setUp(): void
     public function testFill()
     {
         $this->resetConfigs([
-            ConfigHelper::NUMBER_OF_JOB_TO_RUN,
+            QueueHelper::NUMBER_OF_JOB_TO_RUN,
             ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE,
         ]);
 
-        $this->setConfig(ConfigHelper::IS_ACTIVE, '1');
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
         $this->connection->query('TRUNCATE TABLE algoliasearch_queue');
 
         $productBatchQueueProcessor = $this->objectManager->get(ProductBatchQueueProcessor::class);
@@ -84,7 +85,7 @@ public function testFill()
 
     public function testExecute()
     {
-        $this->setConfig(ConfigHelper::IS_ACTIVE, '1');
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
         $this->connection->query('TRUNCATE TABLE algoliasearch_queue');
 
         $productBatchQueueProcessor = $this->objectManager->get(ProductBatchQueueProcessor::class);
@@ -136,16 +137,57 @@ public function testExecute()
         $this->assertEquals(0, count($rows));
     }
 
+    public function testTmpIndexConfig()
+    {
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
+        // Setting "Use a temporary index for full products reindex" configuration to "No"
+        $this->setConfig(QueueHelper::USE_TMP_INDEX, '0');
+        $this->connection->query('TRUNCATE TABLE algoliasearch_queue');
+
+        $productBatchQueueProcessor = $this->objectManager->get(ProductBatchQueueProcessor::class);
+        $productBatchQueueProcessor->processBatch(1);
+
+        $rows = $this->connection->query('SELECT * FROM algoliasearch_queue')->fetchAll();
+        // Without temporary index enabled, there are only 2 jobs (saveConfigurationToAlgolia and buildIndexFull)
+        $this->assertEquals(2, count($rows));
+
+        $indexingJob = $rows[1];
+        $jobData = json_decode($indexingJob['data'], true);
+
+        $this->assertEquals('buildIndexFull', $indexingJob['method']);
+        $this->assertFalse($jobData['options']['useTmpIndex']);
+
+        /** @var Queue $queue */
+        $queue = $this->objectManager->get(Queue::class);
+
+        // Run the first job (saveSettings)
+        $queue->runCron(1, true);
+
+        $this->algoliaConnector->waitLastTask();
+
+        $indices = $this->algoliaConnector->listIndexes();
+
+        $existsDefaultTmpIndex = false;
+        foreach ($indices['items'] as $index) {
+            if ($index['name'] === $this->indexPrefix . 'default_products_tmp') {
+                $existsDefaultTmpIndex = true;
+            }
+        }
+        // Checking if the temporary index hasn't been created
+        $this->assertFalse($existsDefaultTmpIndex, 'Temporary index exists and it should not');
+    }
+
     public function testSettings()
     {
         $this->resetConfigs([
-            ConfigHelper::NUMBER_OF_JOB_TO_RUN,
+            QueueHelper::NUMBER_OF_JOB_TO_RUN,
             ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE,
             ConfigHelper::FACETS,
+            QueueHelper::USE_TMP_INDEX,
             ConfigHelper::PRODUCT_ATTRIBUTES
         ]);
 
-        $this->setConfig(ConfigHelper::IS_ACTIVE, '1');
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
 
         $this->connection->query('DELETE FROM algoliasearch_queue');
 
@@ -178,8 +220,8 @@ public function testSettings()
 
     public function testMergeSettings()
     {
-        $this->setConfig(ConfigHelper::IS_ACTIVE, '1');
-        $this->setConfig(ConfigHelper::NUMBER_OF_JOB_TO_RUN, 1);
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
+        $this->setConfig(QueueHelper::NUMBER_OF_JOB_TO_RUN, 1);
         $this->setConfig(ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE, 300);
 
         $this->connection->query('DELETE FROM algoliasearch_queue');
@@ -791,7 +833,7 @@ public function testGetJobs()
     public function testHugeJob()
     {
         // Default value - maxBatchSize = 1000
-        $this->setConfig(ConfigHelper::NUMBER_OF_JOB_TO_RUN, 10);
+        $this->setConfig(QueueHelper::NUMBER_OF_JOB_TO_RUN, 10);
         $this->setConfig(ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE, 100);
 
         $productIds = range(1, 5000);
@@ -829,7 +871,7 @@ public function testHugeJob()
     public function testMaxSingleJobSize()
     {
         // Default value - maxBatchSize = 1000
-        $this->setConfig(ConfigHelper::NUMBER_OF_JOB_TO_RUN, 10);
+        $this->setConfig(QueueHelper::NUMBER_OF_JOB_TO_RUN, 10);
         $this->setConfig(ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE, 100);
 
         $productIds = range(1, 99);
@@ -870,13 +912,13 @@ public function testMaxSingleJobSize()
     public function testMaxSingleJobsSizeOnProductReindex()
     {
         $this->resetConfigs([
-            ConfigHelper::NUMBER_OF_JOB_TO_RUN,
+            QueueHelper::NUMBER_OF_JOB_TO_RUN,
             ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE,
         ]);
 
-        $this->setConfig(ConfigHelper::IS_ACTIVE, '1');
+        $this->setConfig(QueueHelper::IS_ACTIVE, '1');
 
-        $this->setConfig(ConfigHelper::NUMBER_OF_JOB_TO_RUN, 10);
+        $this->setConfig(QueueHelper::NUMBER_OF_JOB_TO_RUN, 10);
         $this->setConfig(ConfigHelper::NUMBER_OF_ELEMENT_BY_PAGE, 100);
 
         $this->connection->query('TRUNCATE TABLE algoliasearch_queue');