MAGE-1205: fix analytics revenue calculation for placed order event

damcou · damcou · commit c6bd88c2f814 · 2025-05-23T11:35:35.000+02:00
diff --git a/Service/Insights/EventProcessor.php b/Service/Insights/EventProcessor.php
@@ -268,7 +268,7 @@ protected function getQuoteItemDiscount(Item $item): float
      */
     protected function getOrderItemSalePrice(OrderItem $item): float
     {
-        return floatval($item->getPrice()) - $this->getOrderItemCartDiscount($item);
+        return floatval($item->getPriceInclTax()) - $this->getOrderItemCartDiscount($item);
     }
 
     /**
@@ -286,7 +286,7 @@ protected function getOrderItemCartDiscount(OrderItem $item): float
      */
     protected function getOrderItemDiscount(OrderItem $item): float
     {
-        $itemDiscount = floatval($item->getOriginalPrice()) - floatval($item->getPrice());
+        $itemDiscount = floatval($item->getOriginalPrice()) - floatval($item->getPriceInclTax());
         return $itemDiscount + $this->getOrderItemCartDiscount($item);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ protected function getQuoteItemDiscount(Item $item): float`
`268`	`268`	`*/`
`269`	`269`	`protected function getOrderItemSalePrice(OrderItem $item): float`
`270`	`270`	`{`
`271`		`- return floatval($item->getPrice()) - $this->getOrderItemCartDiscount($item);`
	`271`	`+ return floatval($item->getPriceInclTax()) - $this->getOrderItemCartDiscount($item);`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`/**`
`@@ -286,7 +286,7 @@ protected function getOrderItemCartDiscount(OrderItem $item): float`
`286`	`286`	`*/`
`287`	`287`	`protected function getOrderItemDiscount(OrderItem $item): float`
`288`	`288`	`{`
`289`		`- $itemDiscount = floatval($item->getOriginalPrice()) - floatval($item->getPrice());`
	`289`	`+ $itemDiscount = floatval($item->getOriginalPrice()) - floatval($item->getPriceInclTax());`
`290`	`290`	`return $itemDiscount + $this->getOrderItemCartDiscount($item);`
`291`	`291`	`}`
`292`	`292`