MAGE-895: code updated as per code review suggestions

Author: mrahman3177

Block/Configuration.php

@@ -240,8 +240,8 @@ public function getConfiguration()
                 'relatedProductsTitle' => __($config->getRelatedProductsTitle()),
                 'trendingItemsTitle' => __($config->getTrendingItemsTitle()),
                 'addToCartParams' => $addToCartParams,
-                'isLookingSimilarEnabledOnPDP' => $config->isLookingSimilarEnabledOnPDP(),
-                'isLookingSimilarEnabledOnCartPage' => $config->isLookingSimilarEnabledOnShoppingCart(),
+                'isLookingSimilarEnabledInPDP' => $config->isLookingSimilarEnabledInPDP(),
+                'isLookingSimilarEnabledInCartPage' => $config->isLookingSimilarEnabledInShoppingCart(),
                 'lookingSimilarTitle' => __($config->getLookingSimilarTitle())
             ],
             'extensionVersion' => $config->getExtensionVersion(),

Helper/ConfigHelper.php

@@ -138,8 +138,8 @@ class ConfigHelper
     protected const IS_ADDTOCART_ENABLED_IN_RELATED_PRODUCTS = 'algoliasearch_recommend/recommend/related_product/is_addtocart_enabled';
     protected const IS_ADDTOCART_ENABLED_IN_TRENDS_ITEM = 'algoliasearch_recommend/recommend/trends_item/is_addtocart_enabled';
     protected const IS_ADDTOCART_ENABLED_IN_LOOKING_SIMILAR = 'algoliasearch_recommend/recommend/looking_similar/is_addtocart_enabled';
-    protected const IS_LOOKING_SIMILAR_ENABLED_ON_PDP = 'algoliasearch_recommend/recommend/looking_similar/is_looking_similar_enabled_on_pdp';
-    protected const IS_LOOKING_SIMILAR_ENABLED_ON_SHOPPING_CART = 'algoliasearch_recommend/recommend/looking_similar/is_looking_similar_enabled_on_cart_page';
+    protected const IS_LOOKING_SIMILAR_ENABLED_IN_PDP = 'algoliasearch_recommend/recommend/looking_similar/is_looking_similar_enabled_on_pdp';
+    protected const IS_LOOKING_SIMILAR_ENABLED_IN_SHOPPING_CART = 'algoliasearch_recommend/recommend/looking_similar/is_looking_similar_enabled_on_cart_page';
     protected const LOOKING_SIMILAR_TITLE = 'algoliasearch_recommend/recommend/looking_similar/title';
     protected const USE_VIRTUAL_REPLICA_ENABLED = 'algoliasearch_instant/instant/use_virtual_replica';
     protected const AUTOCOMPLETE_KEYBORAD_NAVIAGATION = 'algoliasearch_autocomplete/autocomplete/navigator';
@@ -873,10 +873,10 @@ public function isRecommendLookingSimilarEnabled($storeId = null)
      * @param $storeId
      * @return int
      */
-    public function isLookingSimilarEnabledOnPDP($storeId = null)
+    public function isLookingSimilarEnabledInPDP($storeId = null)
     {
         return (int)$this->configInterface->getValue(
-            self::IS_LOOKING_SIMILAR_ENABLED_ON_PDP,
+            self::IS_LOOKING_SIMILAR_ENABLED_IN_PDP,
             ScopeInterface::SCOPE_STORE,
             $storeId
         );
@@ -894,10 +894,10 @@ public function getLookingSimilarTitle($storeId = null)
      * @param $storeId
      * @return int
      */
-    public function isLookingSimilarEnabledOnShoppingCart($storeId = null)
+    public function isLookingSimilarEnabledInShoppingCart($storeId = null)
     {
         return (int)$this->configInterface->getValue(
-            self::IS_LOOKING_SIMILAR_ENABLED_ON_SHOPPING_CART,
+            self::IS_LOOKING_SIMILAR_ENABLED_IN_SHOPPING_CART,
             ScopeInterface::SCOPE_STORE,
             $storeId
         );

ViewModel/Recommend/Cart.php

@@ -16,7 +16,7 @@ class Cart implements ArgumentInterface
      * @var StoreManagerInterface
      */
     protected $storeManager;
-    
+
     /**
      * @var Session
      */
@@ -81,7 +81,8 @@ public function getAlgoliaRecommendConfiguration()
         return [
             'enabledFBTInCart' => $this->configHelper->isRecommendFrequentlyBroughtTogetherEnabledOnCartPage(),
             'enabledRelatedInCart' => $this->configHelper->isRecommendRelatedProductsEnabledOnCartPage(),
-            'isTrendItemsEnabledInCartPage' => $this->configHelper->isTrendItemsEnabledInShoppingCart()
+            'isTrendItemsEnabledInCartPage' => $this->configHelper->isTrendItemsEnabledInShoppingCart(),
+            'isLookingSimilarEnabledInCartPage' => $this->configHelper->isLookingSimilarEnabledInShoppingCart()
         ];
     }
 }

ViewModel/Recommend/ProductView.php

@@ -68,7 +68,7 @@ public function getAlgoliaRecommendConfiguration()
             'enabledFBT' => $this->configHelper->isRecommendFrequentlyBroughtTogetherEnabled(),
             'enabledRelated' => $this->configHelper->isRecommendRelatedProductsEnabled(),
             'isTrendItemsEnabledInPDP' => $this->configHelper->isTrendItemsEnabledInPDP(),
-            'isLookingSimilarEnabledInPDP' => $this->configHelper->isLookingSimilarEnabledOnPDP()
+            'isLookingSimilarEnabledInPDP' => $this->configHelper->isLookingSimilarEnabledInPDP()
         ];
     }
 }

view/frontend/web/recommend.js

@@ -166,9 +166,9 @@ define([
             }
 
             if (
-                (algoliaConfig.recommend.isLookingSimilarEnabledOnPDP &&
+                (algoliaConfig.recommend.isLookingSimilarEnabledInPDP &&
                     $('body').hasClass('catalog-product-view')) ||
-                (algoliaConfig.recommend.isLookingSimilarEnabledOnCartPage &&
+                (algoliaConfig.recommend.isLookingSimilarEnabledInCartPage &&
                     $('body').hasClass('checkout-cart-index'))
             ) {
                 recommendJs.lookingSimilar({