MAGE-1365 Fix dangling implicit nullable types identified by SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue

Author: cammonro

Controller/Adminhtml/IndexingManager/Reindex.php

@@ -16,6 +16,7 @@
 use Algolia\AlgoliaSearch\Service\Category\BatchQueueProcessor as CategoryBatchQueueProcessor;
 use Algolia\AlgoliaSearch\Service\Page\BatchQueueProcessor as PageBatchQueueProcessor;
 use Algolia\AlgoliaSearch\Service\Product\BatchQueueProcessor as ProductBatchQueueProcessor;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Store\Model\StoreManagerInterface;
 
@@ -131,8 +132,9 @@ protected function isMassAction(array $params): bool
      * @throws AlgoliaException
      * @throws DiagnosticsException
      * @throws NoSuchEntityException
+     * @throws LocalizedException
      */
-    protected function reindexEntities(array $entities, array $storeIds = null, array $entityIds = null): void
+    protected function reindexEntities(array $entities, ?array $storeIds = null, ?array $entityIds = null): void
     {
         foreach ($entities as $entity) {
             $processor = match ($entity) {

Test/Integration/Indexing/MultiStoreTestCase.php

@@ -44,7 +44,7 @@ protected function setUp(): void
 
     protected function reindexToAllStores(
         BatchQueueProcessorInterface $batchQueueProcessor,
-        array $categoryIds = null
+        ?array $categoryIds = null
     ): void
     {
         foreach (array_keys($this->storeManager->getStores()) as $storeId) {