MAGE-1281 Apply new naming convention per review

Author: cammonro

Helper/Entity/ProductHelper.php

@@ -12,7 +12,7 @@
 use Algolia\AlgoliaSearch\Service\IndexOptionsBuilder;
 use Algolia\AlgoliaSearch\Service\Product\FacetBuilder;
 use Algolia\AlgoliaSearch\Service\Product\RecordBuilder as ProductRecordBuilder;
-use Algolia\AlgoliaSearch\Service\ReplicaSettingsHandler;
+use Algolia\AlgoliaSearch\Service\IndexSettingsHandler;
 use Magento\Catalog\Api\Data\ProductInterfaceFactory;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Attribute\Source\Status;
@@ -88,7 +88,7 @@ public function __construct(
         protected ProductInterfaceFactory $productFactory,
         protected ProductRecordBuilder    $productRecordBuilder,
         protected FacetBuilder            $facetBuilder,
-        protected ReplicaSettingsHandler  $replicaSettingsHandler,
+        protected IndexSettingsHandler    $indexSettingsHandler,
     )
     {
         parent::__construct($indexNameFetcher);
@@ -318,11 +318,11 @@ public function setSettings(
     ): void {
         $indexSettings = $this->getIndexSettings($storeId);
 
-        $this->replicaSettingsHandler->setSettings($indexOptions, $indexSettings);
+        $this->indexSettingsHandler->setSettings($indexOptions, $indexSettings);
 
         $this->logger->log('Settings: ' . json_encode($indexSettings));
         if ($saveToTmpIndicesToo) {
-            $this->replicaSettingsHandler->setSettings(
+            $this->indexSettingsHandler->setSettings(
                 $indexTmpOptions,
                 $indexSettings,
                 $indexOptions->getIndexName()

Model/IndicesConfigurator.php

@@ -17,7 +17,7 @@
 use Algolia\AlgoliaSearch\Service\Category\IndexOptionsBuilder as CategoryIndexOptionsBuilder;
 use Algolia\AlgoliaSearch\Service\Page\IndexOptionsBuilder as PageIndexOptionsBuilder;
 use Algolia\AlgoliaSearch\Service\Product\IndexOptionsBuilder as ProductIndexOptionsBuilder;
-use Algolia\AlgoliaSearch\Service\ReplicaSettingsHandler;
+use Algolia\AlgoliaSearch\Service\IndexSettingsHandler;
 use Algolia\AlgoliaSearch\Service\Suggestion\IndexOptionsBuilder as SuggestionIndexOptionsBuilder;
 use Magento\Framework\Exception\NoSuchEntityException;
 
@@ -38,7 +38,7 @@ public function __construct(
         protected SuggestionHelper              $suggestionHelper,
         protected AdditionalSectionHelper       $additionalSectionHelper,
         protected AlgoliaCredentialsManager     $algoliaCredentialsManager,
-        protected ReplicaSettingsHandler        $replicaSettingsHandler,
+        protected IndexSettingsHandler          $indexSettingsHandler,
         protected DiagnosticsLogger             $logger
     ) {}
 
@@ -110,7 +110,7 @@ protected function setCategoriesSettings(int $storeId): void
         $settings = $this->categoryHelper->getIndexSettings($storeId);
         $indexOptions = $this->categoryIndexOptionsBuilder->buildEntityIndexOptions($storeId);
 
-        $this->replicaSettingsHandler->setSettings($indexOptions, $settings);
+        $this->indexSettingsHandler->setSettings($indexOptions, $settings);
 
         $this->logger->log('Index name: ' . $indexOptions->getIndexName());
         $this->logger->log('Settings: ' . json_encode($settings));
@@ -130,7 +130,7 @@ protected function setPagesSettings(int $storeId): void
         $settings = $this->pageHelper->getIndexSettings($storeId);
         $indexOptions = $this->pageIndexOptionsBuilder->buildEntityIndexOptions($storeId);
 
-        $this->replicaSettingsHandler->setSettings($indexOptions, $settings);
+        $this->indexSettingsHandler->setSettings($indexOptions, $settings);
 
         $this->logger->log('Index name: ' . $indexOptions->getIndexName());
         $this->logger->log('Settings: ' . json_encode($settings));
@@ -150,7 +150,7 @@ protected function setQuerySuggestionsSettings(int $storeId): void
         $settings = $this->suggestionHelper->getIndexSettings($storeId);
         $indexOptions = $this->suggestionIndexOptionsBuilder->buildEntityIndexOptions($storeId);
 
-        $this->replicaSettingsHandler->setSettings($indexOptions, $settings);
+        $this->indexSettingsHandler->setSettings($indexOptions, $settings);
 
         $this->logger->log('Index name: ' . $indexOptions->getIndexName());
         $this->logger->log('Settings: ' . json_encode($settings));
@@ -179,7 +179,7 @@ protected function setAdditionalSectionsSettings(int $storeId): void
             $settings = $this->additionalSectionHelper->getIndexSettings($storeId);
             $indexOptions = $this->indexOptionsBuilder->buildWithEnforcedIndex($indexName, $storeId);
 
-            $this->replicaSettingsHandler->setSettings($indexOptions, $settings);
+            $this->indexSettingsHandler->setSettings($indexOptions, $settings);
 
             $this->logger->log('Index name: ' . $indexName);
             $this->logger->log('Settings: ' . json_encode($settings));

Service/ReplicaSettingsHandler.php renamed to Service/IndexSettingsHandler.php

@@ -11,7 +11,7 @@
  *  This class will proxy the settings save operations and forward to replicas based on user configuration
  *  excluding attributes which should never be forwarded
  */
-class ReplicaSettingsHandler
+class IndexSettingsHandler
 {
     /**
      * As replicas are used for sorting we do not want to override these replicas specific configurations

Test/Unit/Service/ReplicaSettingsHandlerTest.php renamed to Test/Unit/Service/IndexSettingsHandlerTest.php

@@ -5,26 +5,26 @@
 use Algolia\AlgoliaSearch\Api\Data\IndexOptionsInterface;
 use Algolia\AlgoliaSearch\Helper\ConfigHelper;
 use Algolia\AlgoliaSearch\Service\AlgoliaConnector;
-use Algolia\AlgoliaSearch\Service\ReplicaSettingsHandler;
+use Algolia\AlgoliaSearch\Service\IndexSettingsHandler;
 use PHPUnit\Framework\TestCase;
 
-class ReplicaSettingsHandlerTest extends TestCase
+class IndexSettingsHandlerTest extends TestCase
 {
     protected ?AlgoliaConnector $connector = null;
 
     protected ?ConfigHelper $config = null;
 
     protected ?IndexOptionsInterface $indexOptions = null;
 
-    private ?ReplicaSettingsHandler $handler = null;
+    private ?IndexSettingsHandler $handler = null;
 
     protected function setUp(): void
     {
         $this->connector = $this->createMock(AlgoliaConnector::class);
         $this->config = $this->createMock(ConfigHelper::class);
         $this->indexOptions = $this->createMock(IndexOptionsInterface::class);
 
-        $this->handler = new ReplicaSettingsHandlerTestable($this->connector, $this->config);
+        $this->handler = new IndexSettingsHandlerTestable($this->connector, $this->config);
     }
 
     public function testSetSettingsWithForwardingEnabledAndMixedSettings(): void

Test/Unit/Service/ReplicaSettingsHandlerTestable.php renamed to Test/Unit/Service/IndexSettingsHandlerTestable.php

@@ -2,9 +2,9 @@
 
 namespace Algolia\AlgoliaSearch\Test\Unit\Service;
 
-use Algolia\AlgoliaSearch\Service\ReplicaSettingsHandler;
+use Algolia\AlgoliaSearch\Service\IndexSettingsHandler;
 
-class ReplicaSettingsHandlerTestable extends ReplicaSettingsHandler
+class IndexSettingsHandlerTestable extends IndexSettingsHandler
 {
     public function splitSettings(...$params): array
     {