MAGE-1153: use existing logic in mergeSettings to remove synonyms duplication

damcou · damcou · commit e11d039f2eb5 · 2024-12-06T10:37:52.000+01:00
diff --git a/Helper/AlgoliaHelper.php b/Helper/AlgoliaHelper.php
@@ -359,7 +359,7 @@ public function mergeSettings($indexName, $settings, $mergeSettingsFrom = '')
         } catch (\Exception $e) {
         }
 
-        $removes = ['slaves', 'replicas', 'decompoundedAttributes'];
+        $removes = ['slaves', 'replicas', 'decompoundedAttributes', 'synonyms'];
 
         if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {
             $removes[] = 'mode';

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ public function mergeSettings($indexName, $settings, $mergeSettingsFrom = '')`
`359`	`359`	`} catch (\Exception $e) {`
`360`	`360`	`}`
`361`	`361`
`362`		`- $removes = ['slaves', 'replicas', 'decompoundedAttributes'];`
	`362`	`+ $removes = ['slaves', 'replicas', 'decompoundedAttributes', 'synonyms'];`
`363`	`363`
`364`	`364`	`if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {`
`365`	`365`	`$removes[] = 'mode';`