Skip to content

Commit e360b68

Browse files
committed
MAGE-804 Added configuration for analytics region
1 parent 675f586 commit e360b68

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

Helper/AnalyticsHelper.php

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,53 +50,44 @@ class AnalyticsHelper
5050
*/
5151
private $analyticsConfig;
5252

53-
/**
54-
* Can be changed through DI
55-
*
56-
* @var string
57-
*/
58-
private $region;
59-
6053
/**
6154
* @param AlgoliaHelper $algoliaHelper
6255
* @param ConfigHelper $configHelper
6356
* @param IndexEntityDataProvider $entityHelper
6457
* @param Logger $logger
65-
* @param string $region
6658
*/
6759
public function __construct(
6860
AlgoliaHelper $algoliaHelper,
6961
ConfigHelper $configHelper,
7062
IndexEntityDataProvider $entityHelper,
71-
Logger $logger,
72-
string $region = 'us'
63+
Logger $logger
7364
) {
7465
$this->algoliaHelper = $algoliaHelper;
7566
$this->configHelper = $configHelper;
7667

7768
$this->entityHelper = $entityHelper;
7869

7970
$this->logger = $logger;
80-
$this->region = $region;
8171
}
8272

8373
private function setupAnalyticsClient()
8474
{
8575
if ($this->analyticsClient) {
8676
return;
8777
}
88-
89-
$this->region = $this->configHelper->getAnalyticsRegion();
78+
79+
$region = $this->configHelper->getAnalyticsRegion();
80+
9081
$this->analyticsClient = AnalyticsClient::create(
9182
$this->configHelper->getApplicationID(),
9283
$this->configHelper->getAPIKey(),
93-
$this->region
84+
$region
9485
);
9586

9687
$this->analyticsConfig = AnalyticsConfig::create(
9788
$this->configHelper->getApplicationID(),
9889
$this->configHelper->getAPIKey(),
99-
$this->region
90+
$region
10091
);
10192
}
10293

0 commit comments

Comments
 (0)