MAGE-1044 Test sorting attribute update

Author: cammonro

Helper/ConfigHelper.php

@@ -1157,7 +1157,7 @@ public function getRawSortingValue(?int $storeId = null): string
      * @param int|null $scopeId
      * @return void
      */
-    public function setSorting(array $sorting, ?string $scope = null, ?int $scopeId = null): void
+    public function setSorting(array $sorting, string $scope = Magento\Framework\App\Config\ScopeConfigInterface::SCOPE_TYPE_DEFAULT, ?int $scopeId = null): void
     {
         $this->configWriter->save(
             self::SORTING_INDICES,

Test/Integration/Product/ReplicaIndexingTest.php

@@ -3,6 +3,7 @@
 namespace Algolia\AlgoliaSearch\Test\Integration\Product;
 
 use Algolia\AlgoliaSearch\Api\Product\ReplicaManagerInterface;
+use Algolia\AlgoliaSearch\Helper\Entity\ProductHelper;
 use Algolia\AlgoliaSearch\Model\Indexer\Product as ProductIndexer;
 use Algolia\AlgoliaSearch\Model\IndicesConfigurator;
 use Algolia\AlgoliaSearch\Test\Integration\IndexingTestCase;
@@ -16,16 +17,17 @@ class ReplicaIndexingTest extends IndexingTestCase
 
     protected ?string $indexSuffix;
 
+    protected ?array $ogSortingState;
+
     public function setUp(): void
     {
         parent::setUp();
         $this->productIndexer = $this->objectManager->get(ProductIndexer::class);
         $this->replicaManager = $this->objectManager->get(ReplicaManagerInterface::class);
-        $this->indicesConfigurator = $this->getObjectManager()->get(IndicesConfigurator::class);
+        $this->indicesConfigurator = $this->objectManager->get(IndicesConfigurator::class);
         $this->indexSuffix = 'products';
 
-        // Replicas will not get created if InstantSearch is not used
-        $this->setConfig('algoliasearch_instant/instant/is_instant_enabled', 1);
+        $this->ogSortingState = $this->configHelper->getSorting();
     }
 
     protected function getIndexName(string $storeIndexPart): string
@@ -38,25 +40,40 @@ public function processFullReindexProducts(): void
         $this->processFullReindex($this->productIndexer, $this->indexSuffix);
     }
 
-    public function testReplicaConfig(): void
+    protected function hasSortingAttribute($sortAttr, $sortDir): bool
     {
         $sorting = $this->configHelper->getSorting();
-        $sortAttr = 'created_at';
-        $sortDir = 'desc';
-
-        // Has created_at sort
-        $this->assertTrue(
-            (bool) array_filter(
-                $sorting,
-                function($sort) use ($sortAttr, $sortDir) {
-                    return $sort['attribute'] == $sortAttr
-                        && $sort['sort'] == $sortDir;
-                }
-            )
+        return (bool) array_filter(
+            $sorting,
+            function($sort) use ($sortAttr, $sortDir) {
+                return $sort['attribute'] == $sortAttr
+                    && $sort['sort'] == $sortDir;
+            }
         );
+    }
 
-        // Expected replica max
+    protected function assertSortingAttribute($sortAttr, $sortDir): void
+    {
+        $this->assertTrue($this->hasSortingAttribute($sortAttr, $sortDir));
+    }
+
+    protected function assertNoSortingAttribute($sortAttr, $sortDir): void
+    {
+        $this->assertTrue(!$this->hasSortingAttribute($sortAttr, $sortDir));
+    }
+
+    public function testReplicaLimits() {
         $this->assertEquals(20, $this->replicaManager->getMaxVirtualReplicasPerIndex());
+    }
+
+    /**
+     * @magentoConfigFixture current_store algoliasearch_instant/instant/is_instant_enabled 1
+     */
+    public function testStandardReplicaConfig(): void
+    {
+        $sortAttr = 'created_at';
+        $sortDir = 'desc';
+        $this->assertSortingAttribute($sortAttr, $sortDir);
 
         $this->indicesConfigurator->saveConfigurationToAlgolia(1);
         $this->algoliaHelper->waitLastTask();
@@ -88,8 +105,57 @@ function($replica) use ($sortIndexName) {
 
     }
 
+    /**
+     * @magentoDbIsolation disabled
+     */
+    public function testVirtualReplicaConfig(): void
+    {
+        $productHelper = $this->objectManager->get(ProductHelper::class);
+        $sortAttr = 'color';
+        $sortDir = 'asc';
+        $attributes = $productHelper->getAllAttributes();
+        $this->assertArrayHasKey($sortAttr, $attributes);
+
+        $this->assertNoSortingAttribute($sortAttr, $sortDir);
+
+        $sorting = $this->configHelper->getSorting();
+        $sorting[] = [
+            'attribute' => $sortAttr,
+            'sort' => $sortDir,
+            'sortLabel' => $sortAttr
+        ];
+        $encoded = json_encode($sorting);
+//        $this->setConfig('algoliasearch_instant/instant_sorts/sorts', $encoded);
+        $this->configHelper->setSorting($sorting);
+
+        $connection = $this->objectManager->create(\Magento\Framework\App\ResourceConnection::class)
+            ->getConnection();
+//        $connection->beginTransaction();
+//        $this->objectManager->get(\Magento\Framework\App\Config\Storage\WriterInterface::class)->save(
+//            \Algolia\AlgoliaSearch\Helper\ConfigHelper::SORTING_INDICES,
+//            $encoded,
+//            'default'
+//        );
+//        $connection->commit();
+
+
+        $select = $connection->select()
+            ->from('core_config_data', 'value')
+            ->where('path = ?', 'algoliasearch_instant/instant_sorts/sorts')
+            ->where('scope = ?', 'default')
+            ->where('scope_id = ?', 0);
+
+        $configValue = $connection->fetchOne($select);
+
+        // Assert that the correct value was written to the database
+        $this->assertEquals($encoded, $configValue);
+
+//        $this->assertSortingAttribute($sortAttr, $sortDir);
+
+    }
+
     public function tearDown(): void
     {
-        $this->setConfig('algoliasearch_instant/instant/is_instant_enabled', 0);
+        $this->configHelper->setSorting($this->ogSortingState);
     }
 }