MAGE-878: code updated as per code review suggestions

mrahman3177 · mrahman3177 · commit fe464ace7bfb · 2024-07-15T10:31:53.000-04:00
diff --git a/Helper/ConfigHelper.php b/Helper/ConfigHelper.php
@@ -236,14 +236,14 @@ public function getAutocompleteSelector($storeId = null)
     }
 
     /**
-     * Returns config value
+     * Returns config flag
      *
      * @param $storeId
-     * @return mixed
+     * @return bool
      */
-    public function includeNonVisibleProductsInIndex($storeId = null)
+    public function includeNonVisibleProductsInIndex($storeId = null): bool
     {
-        return $this->configInterface->getValue(
+        return $this->configInterface->isSetFlag(
             self::INCLUDE_NON_VISIBLE_PRODUCTS_IN_INDEX,
             ScopeInterface::SCOPE_STORE,
             $storeId

Original file line number	Diff line number	Diff line change
`@@ -236,14 +236,14 @@ public function getAutocompleteSelector($storeId = null)`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`/**`
`239`		`- * Returns config value`
	`239`	`+ * Returns config flag`
`240`	`240`	`*`
`241`	`241`	`* @param $storeId`
`242`		`- * @return mixed`
	`242`	`+ * @return bool`
`243`	`243`	`*/`
`244`		`- public function includeNonVisibleProductsInIndex($storeId = null)`
	`244`	`+ public function includeNonVisibleProductsInIndex($storeId = null): bool`
`245`	`245`	`{`
`246`		`- return $this->configInterface->getValue(`
	`246`	`+ return $this->configInterface->isSetFlag(`
`247`	`247`	`self::INCLUDE_NON_VISIBLE_PRODUCTS_IN_INDEX,`
`248`	`248`	`ScopeInterface::SCOPE_STORE,`
`249`	`249`	`$storeId`