MAGE-1383 Address Codacy complaints #1798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These static rules seem pretty antiquated and switching to things like imperative for loops would not be the right way to go here IMO. Declarative style is the right approach for PHP 8.2+. Putting this on hold for now. |
cammonro
force-pushed
the
chore/MAGE-1383-codacy-complaints
branch
from
a153bba to
987d550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Certain rulesets are triggering on Codacy that may be false positives. This PR aims to address them.
Adding unit tests to ensure parity with these changes.
Result