Skip to content

Commit 07314da

Browse files
committed
fix: types
1 parent 8d06b0c commit 07314da

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

scripts/config.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ export function getClientsConfigField(
88
pathToField: string[] | string,
99
required: boolean = true,
1010
): any {
11+
if (typeof clientsConfig[language] !== 'object') {
12+
throw new Error(`${language} doesn't exist in clients.config.json`);
13+
}
14+
1115
const config: LanguageConfig = clientsConfig[language];
1216
const path = Array.isArray(pathToField) ? pathToField : [pathToField];
1317

@@ -42,11 +46,11 @@ export function getTestOutputFolder(language: Language): string {
4246
}
4347

4448
export function getDockerImage(language?: Language): string | undefined {
45-
if (CI || !language || !('dockerImage' in clientsConfig[language])) {
49+
if (CI || !language) {
4650
return undefined;
4751
}
4852

49-
return getClientsConfigField(language, 'dockerImage');
53+
return getClientsConfigField(language, 'dockerImage', false);
5054
}
5155

5256
/**
@@ -57,7 +61,7 @@ export function getPackageVersionDefault(language: Language): string {
5761
}
5862

5963
export function getGitHubUrl(language: Language, options?: { token: string }): string {
60-
const { gitRepoId } = clientsConfig[language];
64+
const gitRepoId = getClientsConfigField(language, ['gitRepoId']);
6165

6266
// GitHub Action provides a default token for authentication
6367
// https://docs.github.com/en/actions/security-guides/automatic-token-authentication

scripts/husky/pre-commit.mjs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,14 @@ async function run(command) {
1818

1919
export function getPatterns() {
2020
const entries = patterns;
21-
for (const [language, { tests }] of Object.entries(clientConfig)) {
22-
entries.unshift(`tests/output/${language}/${tests.outputFolder}/client/**`);
23-
entries.unshift(`tests/output/${language}/${tests.outputFolder}/requests/**`);
24-
entries.unshift(`tests/output/${language}/${tests.outputFolder}/e2e/**`);
25-
entries.unshift(`tests/output/${language}/${tests.outputFolder}/benchmark/**`);
21+
for (const [language, opts] of Object.entries(clientConfig)) {
22+
if (typeof opts !== 'object') {
23+
continue;
24+
}
25+
entries.unshift(`tests/output/${language}/${opts.tests.outputFolder}/client/**`);
26+
entries.unshift(`tests/output/${language}/${opts.tests.outputFolder}/requests/**`);
27+
entries.unshift(`tests/output/${language}/${opts.tests.outputFolder}/e2e/**`);
28+
entries.unshift(`tests/output/${language}/${opts.tests.outputFolder}/benchmark/**`);
2629
}
2730
return entries;
2831
}

scripts/release/updateAPIVersions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type { Changelog, Versions } from './types.ts';
1313
async function updateConfigFiles(versionsToRelease: Versions): Promise<void> {
1414
// update the other versions in clients.config.json
1515
for (const lang of Object.keys(versionsToRelease) as Language[]) {
16-
if (versionsToRelease[lang]?.next) {
16+
if (typeof clientsConfig[lang] == 'object' && versionsToRelease[lang]?.next) {
1717
clientsConfig[lang].packageVersion = versionsToRelease[lang].next;
1818
}
1919
}

0 commit comments

Comments
 (0)