Skip to content

Commit 119a770

Browse files
committed
of course an edge case for js
1 parent bdd5658 commit 119a770

File tree

2 files changed

+23
-6
lines changed

2 files changed

+23
-6
lines changed

scripts/cts/testServer/algoliaMock.ts

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,41 @@ function addRoutes(app: Express): void {
3838
});
3939
});
4040

41-
app.get('/1/indexes/unknownField/settings', (req, res) => {
41+
app.get('/1/indexes/:indexName/settings', (req, res) => {
42+
const lang = req.params.indexName.match(/^cts_e2e_unknownField_(.*)$/)?.[1] as string;
43+
let unknown = {};
44+
if (lang !== 'javascript' && lang !== 'python') {
45+
// js and python just put the response in a map, there is no strict parsing.
46+
unknown = {
47+
unknownFieldNameThatWillNeverBeAddedToTheSpecIHope: 'hello',
48+
};
49+
}
50+
4251
res.json({
4352
minWordSizefor1Typo: 12,
4453
minWordSizefor2Typos: 13,
4554
hitsPerPage: 14,
46-
unknownFieldNameThatWillNeverBeAddedToTheSpecIHope: 'hello',
55+
...unknown,
4756
});
4857
});
4958

50-
app.get('/1/indexes/unknownFieldInOneOf/rules/:objectID', (req, res) => {
59+
app.get('/1/indexes/:indexName/rules/:objectID', (req, res) => {
60+
const lang = req.params.indexName.match(/^cts_e2e_unknownFieldNested_(.*)$/)?.[1] as string;
61+
let unknown = {};
62+
if (lang !== 'javascript' && lang !== 'python') {
63+
unknown = {
64+
unknownFieldNameThatWillNeverBeAddedToTheSpecIHope: 'hello',
65+
};
66+
}
67+
5168
res.json({
5269
objectID: req.params.objectID,
5370
consequence: {
5471
promote: [
5572
{
5673
objectID: '1',
5774
position: 10,
58-
unknownFieldNameThatWillNeverBeAddedToTheSpecIHope: 'hello',
75+
...unknown,
5976
},
6077
],
6178
},

tests/CTS/client/search/api.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@
246246
"type": "method",
247247
"method": "getSettings",
248248
"parameters": {
249-
"indexName": "unknownField"
249+
"indexName": "cts_e2e_unknownField_${{language}}"
250250
},
251251
"expected": {
252252
"type": "response",
@@ -280,7 +280,7 @@
280280
"type": "method",
281281
"method": "getRule",
282282
"parameters": {
283-
"indexName": "unknownFieldInOneOf",
283+
"indexName": "cts_e2e_unknownFieldNested_${{language}}",
284284
"objectID": "ruleObjectID"
285285
},
286286
"expected": {

0 commit comments

Comments
 (0)