remove build step

Author: millotp

.github/workflows/check.yml

@@ -219,7 +219,7 @@ jobs:
         run: cd clients/algoliasearch-client-javascript && YARN_ENABLE_HARDENED_MODE=0 YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
 
       - name: Build clients
-        run: ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).buildCommand }}
+        run: cd clients/algoliasearch-client-javascript && yarn build
 
       - name: Build the playground
         run: yarn cli build playground javascript ${{ fromJSON(needs.setup.outputs.JAVASCRIPT_DATA).toRun }}
@@ -334,6 +334,8 @@ jobs:
       - name: Generate clients
         run: yarn cli generate ${{ matrix.client.language }} ${{ matrix.client.toRun }}
 
+      # no need to build the clients here, it will be done in the test Run CTS step anyway.
+
       - name: Update composer.lock
         if: ${{ matrix.client.language == 'php' && startsWith(github.head_ref, 'chore/renovateBaseBranch')  && matrix.client.isMainVersion }}
         run: cd ${{ matrix.client.path }} && composer update
@@ -346,9 +348,6 @@ jobs:
           find Sources  -type f | rev | cut -d '/' -f1 | rev | sort | uniq -d
           [ $(find Sources  -type f | rev | cut -d '/' -f1 | rev | sort | uniq -d | wc -l) -gt 0 ] && echo "Duplicates found" && exit 1 || echo "No duplicate found"
 
-      - name: Build clients
-        run: ${{ matrix.client.buildCommand }}
-
       - name: Build the playground
         run: yarn cli build playground ${{ matrix.client.language }}
 

scripts/ci/githubActions/createMatrix.ts

@@ -83,7 +83,6 @@ async function createClientMatrix(baseBranch: string): Promise<void> {
       language,
       path: matrix[language].path,
       toRun,
-      buildCommand: `yarn cli build clients ${language} ${toRun}`,
       testsRootFolder,
       // We delete tests to ensure the CI only run tests against what changed.
       testsToDelete: `${testsOutputBase}/client ${testsOutputBase}/requests ${testsOutputBase}/e2e ${testsOutputBase}/benchmark`,
@@ -112,7 +111,6 @@ async function createClientMatrix(baseBranch: string): Promise<void> {
         languageMatrix.testsToStore = `${languageMatrix.testsToStore} ${testsRootFolder}/build.gradle`;
         break;
       case 'javascript':
-        languageMatrix.buildCommand = `cd ${matrix[language].path} && yarn build`;
         languageMatrix.testsToStore = `${languageMatrix.testsToStore} ${testsRootFolder}/package.json`;
 
         setOutput('JAVASCRIPT_DATA', JSON.stringify(languageMatrix));

scripts/ci/githubActions/types.ts

@@ -23,10 +23,6 @@ export type ClientMatrix = {
      * The client language.
      */
     language: string;
-    /**
-     * The command to build the clients.
-     */
-    buildCommand: string;
     /**
      * The root of the test folder.
      */