Skip to content

Commit 2796014

Browse files
millotpmillotp
committed
good ?
1 parent 9005027 commit 2796014

File tree

4 files changed

+117
-7
lines changed

4 files changed

+117
-7
lines changed

‎.eslintrc.cjs‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,17 @@ module.exports = {
209209

210210
plugins: ['@vitest/eslint-plugin'],
211211
},
212+
{
213+
files: ['guides/**/*.ts'],
214+
215+
rules: {
216+
'no-console': 0,
217+
218+
// TODO: remove this
219+
'@typescript-eslint/no-unused-vars': 0,
220+
'@typescript-eslint/explicit-function-return-type': 0,
221+
},
222+
},
212223
{
213224
files: ['*.json'],
214225
parserOptions: {

‎generators/src/main/java/com/algolia/codegen/cts/tests/Snippet.java‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public class Snippet {
1313

1414
public String testName;
1515
public boolean isSnippet;
16+
public boolean ignoreResponse;
1617

1718
public String method;
1819
public Map<String, Object> parameters;
@@ -33,6 +34,7 @@ public String toString() {
3334
sb.append("class Request {\n");
3435
sb.append(" testName: ").append(testName).append("\n");
3536
sb.append(" isSnippet").append(isSnippet).append("\n");
37+
sb.append(" ignoreResponse").append(ignoreResponse).append("\n");
3638
sb.append(" method: ").append(method).append("\n");
3739
sb.append(" parameters: ").append(parameters).append("\n");
3840
sb.append(" requestOptions: ").append(requestOptions).append("\n");
@@ -73,11 +75,13 @@ public void addMethodCall(Map<String, Object> context, ParametersWithDataType pa
7375

7476
// Determines whether the endpoint is expected to return a response payload deserialized
7577
// and therefore a variable to store it into.
76-
context.put("hasResponse", true);
78+
if (!ignoreResponse) {
79+
context.put("hasResponse", true);
7780

78-
for (CodegenResponse response : ope.responses) {
79-
if (response.code.equals("204")) {
80-
context.put("hasResponse", false);
81+
for (CodegenResponse response : ope.responses) {
82+
if (response.code.equals("204")) {
83+
context.put("hasResponse", false);
84+
}
8185
}
8286
}
8387

‎tests/CTS/guides/search/snippets.json‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
{
22
"saveObjectsMovies": {
33
"method": "saveObjects",
4+
"ignoreResponse": true,
45
"parameters": {
56
"indexName": "movies_index",
6-
"objects": {
7-
"$var": "objects"
8-
}
7+
"objects": [
8+
{
9+
"$var": "objects"
10+
}
11+
]
912
}
1013
}
1114
}

‎yarn.lock‎

Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ __metadata:
115115
languageName: node
116116
linkType: soft
117117

118+
"@algolia/client-abtesting@link:../../clients/algoliasearch-client-javascript/packages/client-abtesting::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
119+
version: 0.0.0-use.local
120+
resolution: "@algolia/client-abtesting@link:../../clients/algoliasearch-client-javascript/packages/client-abtesting::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
121+
languageName: node
122+
linkType: soft
123+
118124
"@algolia/client-abtesting@link:../../clients/algoliasearch-client-javascript/packages/client-abtesting::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
119125
version: 0.0.0-use.local
120126
resolution: "@algolia/client-abtesting@link:../../clients/algoliasearch-client-javascript/packages/client-abtesting::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -127,6 +133,12 @@ __metadata:
127133
languageName: node
128134
linkType: soft
129135

136+
"@algolia/client-analytics@link:../../clients/algoliasearch-client-javascript/packages/client-analytics::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
137+
version: 0.0.0-use.local
138+
resolution: "@algolia/client-analytics@link:../../clients/algoliasearch-client-javascript/packages/client-analytics::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
139+
languageName: node
140+
linkType: soft
141+
130142
"@algolia/client-analytics@link:../../clients/algoliasearch-client-javascript/packages/client-analytics::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
131143
version: 0.0.0-use.local
132144
resolution: "@algolia/client-analytics@link:../../clients/algoliasearch-client-javascript/packages/client-analytics::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -139,6 +151,12 @@ __metadata:
139151
languageName: node
140152
linkType: soft
141153

154+
"@algolia/client-common@link:../../clients/algoliasearch-client-javascript/packages/client-common::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
155+
version: 0.0.0-use.local
156+
resolution: "@algolia/client-common@link:../../clients/algoliasearch-client-javascript/packages/client-common::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
157+
languageName: node
158+
linkType: soft
159+
142160
"@algolia/client-common@link:../../clients/algoliasearch-client-javascript/packages/client-common::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
143161
version: 0.0.0-use.local
144162
resolution: "@algolia/client-common@link:../../clients/algoliasearch-client-javascript/packages/client-common::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -151,6 +169,12 @@ __metadata:
151169
languageName: node
152170
linkType: soft
153171

172+
"@algolia/client-insights@link:../../clients/algoliasearch-client-javascript/packages/client-insights::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
173+
version: 0.0.0-use.local
174+
resolution: "@algolia/client-insights@link:../../clients/algoliasearch-client-javascript/packages/client-insights::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
175+
languageName: node
176+
linkType: soft
177+
154178
"@algolia/client-insights@link:../../clients/algoliasearch-client-javascript/packages/client-insights::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
155179
version: 0.0.0-use.local
156180
resolution: "@algolia/client-insights@link:../../clients/algoliasearch-client-javascript/packages/client-insights::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -163,6 +187,12 @@ __metadata:
163187
languageName: node
164188
linkType: soft
165189

190+
"@algolia/client-personalization@link:../../clients/algoliasearch-client-javascript/packages/client-personalization::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
191+
version: 0.0.0-use.local
192+
resolution: "@algolia/client-personalization@link:../../clients/algoliasearch-client-javascript/packages/client-personalization::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
193+
languageName: node
194+
linkType: soft
195+
166196
"@algolia/client-personalization@link:../../clients/algoliasearch-client-javascript/packages/client-personalization::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
167197
version: 0.0.0-use.local
168198
resolution: "@algolia/client-personalization@link:../../clients/algoliasearch-client-javascript/packages/client-personalization::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -175,6 +205,12 @@ __metadata:
175205
languageName: node
176206
linkType: soft
177207

208+
"@algolia/client-query-suggestions@link:../../clients/algoliasearch-client-javascript/packages/client-query-suggestions::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
209+
version: 0.0.0-use.local
210+
resolution: "@algolia/client-query-suggestions@link:../../clients/algoliasearch-client-javascript/packages/client-query-suggestions::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
211+
languageName: node
212+
linkType: soft
213+
178214
"@algolia/client-query-suggestions@link:../../clients/algoliasearch-client-javascript/packages/client-query-suggestions::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
179215
version: 0.0.0-use.local
180216
resolution: "@algolia/client-query-suggestions@link:../../clients/algoliasearch-client-javascript/packages/client-query-suggestions::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -187,6 +223,12 @@ __metadata:
187223
languageName: node
188224
linkType: soft
189225

226+
"@algolia/client-search@link:../../clients/algoliasearch-client-javascript/packages/client-search::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
227+
version: 0.0.0-use.local
228+
resolution: "@algolia/client-search@link:../../clients/algoliasearch-client-javascript/packages/client-search::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
229+
languageName: node
230+
linkType: soft
231+
190232
"@algolia/client-search@link:../../clients/algoliasearch-client-javascript/packages/client-search::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
191233
version: 0.0.0-use.local
192234
resolution: "@algolia/client-search@link:../../clients/algoliasearch-client-javascript/packages/client-search::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -199,12 +241,24 @@ __metadata:
199241
languageName: node
200242
linkType: soft
201243

244+
"@algolia/ingestion@link:../../clients/algoliasearch-client-javascript/packages/ingestion::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
245+
version: 0.0.0-use.local
246+
resolution: "@algolia/ingestion@link:../../clients/algoliasearch-client-javascript/packages/ingestion::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
247+
languageName: node
248+
linkType: soft
249+
202250
"@algolia/ingestion@link:../../clients/algoliasearch-client-javascript/packages/ingestion::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
203251
version: 0.0.0-use.local
204252
resolution: "@algolia/ingestion@link:../../clients/algoliasearch-client-javascript/packages/ingestion::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
205253
languageName: node
206254
linkType: soft
207255

256+
"@algolia/monitoring@link:../../clients/algoliasearch-client-javascript/packages/monitoring::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
257+
version: 0.0.0-use.local
258+
resolution: "@algolia/monitoring@link:../../clients/algoliasearch-client-javascript/packages/monitoring::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
259+
languageName: node
260+
linkType: soft
261+
208262
"@algolia/monitoring@link:../../clients/algoliasearch-client-javascript/packages/monitoring::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
209263
version: 0.0.0-use.local
210264
resolution: "@algolia/monitoring@link:../../clients/algoliasearch-client-javascript/packages/monitoring::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -217,6 +271,12 @@ __metadata:
217271
languageName: node
218272
linkType: soft
219273

274+
"@algolia/recommend@link:../../clients/algoliasearch-client-javascript/packages/recommend::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
275+
version: 0.0.0-use.local
276+
resolution: "@algolia/recommend@link:../../clients/algoliasearch-client-javascript/packages/recommend::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
277+
languageName: node
278+
linkType: soft
279+
220280
"@algolia/recommend@link:../../clients/algoliasearch-client-javascript/packages/recommend::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
221281
version: 0.0.0-use.local
222282
resolution: "@algolia/recommend@link:../../clients/algoliasearch-client-javascript/packages/recommend::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -229,6 +289,12 @@ __metadata:
229289
languageName: node
230290
linkType: soft
231291

292+
"@algolia/requester-node-http@link:../../clients/algoliasearch-client-javascript/packages/requester-node-http::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
293+
version: 0.0.0-use.local
294+
resolution: "@algolia/requester-node-http@link:../../clients/algoliasearch-client-javascript/packages/requester-node-http::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
295+
languageName: node
296+
linkType: soft
297+
232298
"@algolia/requester-node-http@link:../../clients/algoliasearch-client-javascript/packages/requester-node-http::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
233299
version: 0.0.0-use.local
234300
resolution: "@algolia/requester-node-http@link:../../clients/algoliasearch-client-javascript/packages/requester-node-http::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -2491,6 +2557,12 @@ __metadata:
24912557
languageName: node
24922558
linkType: soft
24932559

2560+
"algoliasearch@link:../../clients/algoliasearch-client-javascript/packages/algoliasearch::locator=javascript-guides%40workspace%3Aguides%2Fjavascript":
2561+
version: 0.0.0-use.local
2562+
resolution: "algoliasearch@link:../../clients/algoliasearch-client-javascript/packages/algoliasearch::locator=javascript-guides%40workspace%3Aguides%2Fjavascript"
2563+
languageName: node
2564+
linkType: soft
2565+
24942566
"algoliasearch@link:../../clients/algoliasearch-client-javascript/packages/algoliasearch::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript":
24952567
version: 0.0.0-use.local
24962568
resolution: "algoliasearch@link:../../clients/algoliasearch-client-javascript/packages/algoliasearch::locator=javascript-snippets%40workspace%3Asnippets%2Fjavascript"
@@ -5804,6 +5876,26 @@ __metadata:
58045876
languageName: node
58055877
linkType: hard
58065878

5879+
"javascript-guides@workspace:guides/javascript":
5880+
version: 0.0.0-use.local
5881+
resolution: "javascript-guides@workspace:guides/javascript"
5882+
dependencies:
5883+
"@algolia/client-abtesting": "link:../../clients/algoliasearch-client-javascript/packages/client-abtesting"
5884+
"@algolia/client-analytics": "link:../../clients/algoliasearch-client-javascript/packages/client-analytics"
5885+
"@algolia/client-common": "link:../../clients/algoliasearch-client-javascript/packages/client-common"
5886+
"@algolia/client-insights": "link:../../clients/algoliasearch-client-javascript/packages/client-insights"
5887+
"@algolia/client-personalization": "link:../../clients/algoliasearch-client-javascript/packages/client-personalization"
5888+
"@algolia/client-query-suggestions": "link:../../clients/algoliasearch-client-javascript/packages/client-query-suggestions"
5889+
"@algolia/client-search": "link:../../clients/algoliasearch-client-javascript/packages/client-search"
5890+
"@algolia/ingestion": "link:../../clients/algoliasearch-client-javascript/packages/ingestion"
5891+
"@algolia/monitoring": "link:../../clients/algoliasearch-client-javascript/packages/monitoring"
5892+
"@algolia/recommend": "link:../../clients/algoliasearch-client-javascript/packages/recommend"
5893+
"@algolia/requester-node-http": "link:../../clients/algoliasearch-client-javascript/packages/requester-node-http"
5894+
algoliasearch: "link:../../clients/algoliasearch-client-javascript/packages/algoliasearch"
5895+
typescript: "npm:5.6.2"
5896+
languageName: unknown
5897+
linkType: soft
5898+
58075899
"javascript-playground@workspace:playground/javascript/node":
58085900
version: 0.0.0-use.local
58095901
resolution: "javascript-playground@workspace:playground/javascript/node"

0 commit comments

Comments
 (0)