chore: assert long lasting requests on the ingestion api (#4615)

shortcuts · web-flow · commit 2ced1c526bf1 · 2025-04-01T13:02:21.000Z
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/configuration.rb b/clients/algoliasearch-client-ruby/lib/algolia/configuration.rb
@@ -25,9 +25,9 @@ def initialize(app_id, api_key, hosts, client_name, opts = {})
       @app_id = app_id
       @api_key = api_key
       @client_side_validation = opts[:client_side_validation].nil? ? true : opts[:client_side_validation]
-      @connect_timeout = opts[:connect_timeout] || 2_000
-      @read_timeout = opts[:read_timeout] || 5_000
-      @write_timeout = opts[:write_timeout] || 30_000
+      @connect_timeout = opts[:connect_timeout]
+      @read_timeout = opts[:read_timeout]
+      @write_timeout = opts[:write_timeout]
       @compression_type = opts[:compression_type] || "none"
       @requester = opts[:requester]
 
diff --git a/scripts/cts/testServer/timeout.ts b/scripts/cts/testServer/timeout.ts
@@ -102,6 +102,12 @@ function addRoutes(app: express.Express): void {
     res.setHeader('Content-Type', 'text/html');
     res.status(429).send('<html><body>429 Too Many Requests</body></html>');
   });
+
+  app.get('/1/long-wait', (req, res) => {
+    setTimeout(() => {
+      res.json({ message: 'OK' });
+    }, 8000);
+  });
 }
 
 export function timeoutServer(): Promise<Server> {
diff --git a/templates/javascript/tests/client/tests.mustache b/templates/javascript/tests/client/tests.mustache
@@ -55,7 +55,7 @@ describe('{{testType}}', () => {
       }
       {{/times}}
     {{/steps}}
-  }, 15000);
+  }, 25000);
 
   {{/tests}}
 });
diff --git a/templates/ruby/api.mustache b/templates/ruby/api.mustache
@@ -30,18 +30,6 @@ module {{moduleName}}
         region = nil
       end
 
-      if opts.nil? || opts[:connect_timeout].nil?
-        opts[:connect_timeout] = {{x-timeouts.server.connect}}
-      end
-
-      if opts.nil? || opts[:read_timeout].nil?
-        opts[:read_timeout] = {{x-timeouts.server.read}}
-      end
-
-      if opts.nil? || opts[:write_timeout].nil?
-        opts[:write_timeout] = {{x-timeouts.server.write}}
-      end
-
       {{^fallbackToAliasHost}}
       raise "`region` is required and must be one of the following: #{regions.join(', ')}" if region.nil? || !region.is_a?(String) || !regions.include?(region)
       {{/fallbackToAliasHost}}
@@ -70,6 +58,18 @@ module {{moduleName}}
     end
 
     def self.create_with_config(config)
+      if config.connect_timeout.nil? ||config.connect_timeout.empty?
+        config.connect_timeout = {{x-timeouts.server.connect}}
+      end
+
+      if config.read_timeout.nil? || config.read_timeout.empty?
+        config.read_timeout = {{x-timeouts.server.read}}
+      end
+
+      if config.write_timeout.nil? || config.write_timeout.empty?
+        config.write_timeout = {{x-timeouts.server.write}}
+      end
+
       new(config)
     end
 
diff --git a/tests/CTS/client/ingestion/api.json b/tests/CTS/client/ingestion/api.json
@@ -77,6 +77,36 @@
       }
     ]
   },
+  {
+    "testName": "can leave call opened for a long time",
+    "autoCreateClient": false,
+    "steps": [
+      {
+        "type": "createClient",
+        "parameters": {
+          "appId": "test-app-id",
+          "apiKey": "test-api-key",
+          "region": "us",
+          "customHosts": [
+            {
+              "port": 6676
+            }
+          ]
+        }
+      },
+      {
+        "type": "method",
+        "method": "customGet",
+        "parameters": {
+          "path": "1/long-wait"
+        },
+        "expected": {
+          "type": "response",
+          "match": {"message":"OK"}
+        }
+      }
+    ]
+  },
   {
     "testName": "endpoint level timeout",
     "steps": [
diff --git a/tests/output/javascript/yarn.lock b/tests/output/javascript/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ describe('{{testType}}', () => {`
`55`	`55`	`}`
`56`	`56`	`{{/times}}`
`57`	`57`	`{{/steps}}`
`58`		`- }, 15000);`
	`58`	`+ }, 25000);`
`59`	`59`
`60`	`60`	`{{/tests}}`
`61`	`61`	`});`