fix(cts): assert the error of chunkedBatch helpers (#3418)

Author: millotp

scripts/cts/testServer/chunkWrapper.ts

@@ -33,6 +33,11 @@ function addRoutes(app: Express): void {
     if (!chunkWrapperState[lang]) {
       chunkWrapperState[lang] = {};
     }
+
+    if (req.headers['x-algolia-api-key'] === 'wrong-api-key') {
+      res.status(403).json({ message: 'Invalid Application-ID or API key', status: 403 });
+      return;
+    }
     chunkWrapperState[lang][helper] = (chunkWrapperState[lang][helper] ?? 0) + 1;
     switch (helper) {
       case 'saveObjects':

tests/CTS/client/search/helpers.json

@@ -220,6 +220,56 @@
       }
     ]
   },
+  {
+    "testName": "saveObjects should report errors",
+    "autoCreateClient": false,
+    "steps": [
+      {
+        "type": "createClient",
+        "parameters": {
+          "appId": "test-app-id",
+          "apiKey": "wrong-api-key",
+          "customHosts": [
+            {
+              "host": "${{localhost}}",
+              "port": 6680
+            }
+          ]
+        }
+      },
+      {
+        "type": "method",
+        "method": "saveObjects",
+        "parameters": {
+          "indexName": "cts_e2e_saveObjects_${{language}}",
+          "objects": [
+            {
+              "objectID": "1",
+              "name": "Adam"
+            },
+            {
+              "objectID": "2",
+              "name": "Benoit"
+            }
+          ]
+        },
+        "expected": {
+          "error": {
+            "csharp": "{\\\"message\\\":\\\"Invalid Application-ID or API key\\\",\\\"status\\\":403}",
+            "go": "API error [403] {\\\"message\\\":\\\"Invalid Application-ID or API key\\\",\\\"status\\\":403}",
+            "java": "Status Code: 403 - {\\\"message\\\":\\\"Invalid Application-ID or API key\\\",\\\"status\\\":403}",
+            "javascript": "Invalid Application-ID or API key",
+            "kotlin": "Client request(POST http://${{localhost}}:6680/1/indexes/cts_e2e_saveObjects_kotlin/batch) invalid: 403 Forbidden. Text: \\\"{\\\"message\\\":\\\"Invalid Application-ID or API key\\\",\\\"status\\\":403}\\\"",
+            "php": "Invalid Application-ID or API key",
+            "python": "Invalid Application-ID or API key",
+            "ruby": "Invalid Application-ID or API key",
+            "scala": "Invalid Application-ID or API key",
+            "swift": "HTTP error: Status code: 403 Message: Invalid Application-ID or API key"
+          }
+        }
+      }
+    ]
+  },
   {
     "testName": "call partialUpdateObjects with createIfNotExists=true",
     "autoCreateClient": false,

tests/output/javascript/yarn.lock

@@ -938,12 +938,12 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/node@npm:20.14.10":
-  version: 20.14.10
-  resolution: "@types/node@npm:20.14.10"
+"@types/node@npm:20.14.11":
+  version: 20.14.11
+  resolution: "@types/node@npm:20.14.11"
   dependencies:
     undici-types: "npm:~5.26.4"
-  checksum: 10/672892cf94d0d95cf052f11271990686a0fd204cd1e5fe7a4ef240e5315e06711765dc47b9ec98627d3adac18b8c92bb7e2d8db21d18faa20bc3e3203a143e79
+  checksum: 10/344e1ce1ed16c86ed1c4209ab4d1de67db83dd6b694a6fabe295c47144dde2c58dabddae9f39a0a2bdd246e95f8d141ccfe848e464884b48b8918df4f7788025
   languageName: node
   linkType: hard
 
@@ -2067,7 +2067,7 @@ __metadata:
     "@algolia/recommend": "link:../../../clients/algoliasearch-client-javascript/packages/recommend"
     "@algolia/requester-node-http": "link:../../../clients/algoliasearch-client-javascript/packages/requester-node-http"
     "@types/jest": "npm:29.5.12"
-    "@types/node": "npm:20.14.10"
+    "@types/node": "npm:20.14.11"
     algoliasearch: "link:../../../clients/algoliasearch-client-javascript/packages/algoliasearch"
     dotenv: "npm:16.4.5"
     jest: "npm:29.7.0"

tests/output/scala/src/test/scala/algoliasearch/package.scala

@@ -16,8 +16,12 @@ package object algoliasearch {
   @targetName("assertErrorFuture")
   def assertError(message: String)(call: => Future[_])(implicit ec: ExecutionContextExecutor): Unit = {
     Await.ready(call, Duration.Inf).value.get match {
-      case Failure(exception) => assert(exception.getMessage == message, s"Error message does not match, expected: $message, got: ${exception.getMessage}")
-      case Success(_)         => assert(false, "Future should have failed")
+      case Failure(exception) =>
+        assert(
+          exception.getMessage == message,
+          s"Error message does not match, expected: $message, got: ${exception.getMessage}"
+        )
+      case Success(_) => assert(false, "Future should have failed")
     }
   }
 }