fix(ruby): use rubyfmt instead of rubocop (#3334)

Author: millotp

.github/actions/setup/action.yml

@@ -170,6 +170,15 @@ runs:
         ruby-version: ${{ steps.versions.outputs.RUBY_VERSION }}
         bundler-cache: true
 
+    - name: Install Ruby formatter
+      if: ${{ inputs.language == 'ruby' }}
+      shell: bash
+      run: |
+        curl --retry 3 -L https://github.com/fables-tales/rubyfmt/releases/download/v0.10.0/rubyfmt-v0.10.0-Linux-x86_64.tar.gz > rubyfmt.tar.gz
+        tar -xzf rubyfmt.tar.gz
+        mv tmp/releases/v0.10.0-Linux/rubyfmt /usr/local/bin
+        rm -rf rubyfmt.tar.gz tmp
+
     # Csharp
     - name: Install dotnet
       if: ${{ inputs.language == 'csharp' }}

clients/algoliasearch-client-ruby/.rubocop.yml

@@ -1,6 +1,4 @@
 require 'bundler/gem_tasks'
-require 'rubocop/rake_task'
 
 task(:default) { system 'rake --tasks' }
 
-RuboCop::RakeTask.new

clients/algoliasearch-client-ruby/Rakefile

@@ -31,5 +31,4 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'rubocop'
 end

clients/algoliasearch-client-ruby/algolia.gemspec

@@ -118,7 +118,6 @@ export const patterns = [
 
   // Ruby
   '!snippets/ruby/Gemfile',
-  '!snippets/ruby/.rubocop.yml',
   '!clients/algoliasearch-client-ruby/**',
   'clients/algoliasearch-client-ruby/Gemfile.lock',
   'clients/algoliasearch-client-ruby/lib/algolia/**',
@@ -130,6 +129,8 @@ export const patterns = [
   '!clients/algoliasearch-client-ruby/lib/algolia/user_agent.rb',
   '!clients/algoliasearch-client-ruby/lib/algolia/transport/**',
 
+  'tests/output/ruby/Gemfile.lock',
+
   // Scala
   '!snippets/scala/**',
   'snippets/scala/src/**',

config/generation.config.mjs

@@ -1,4 +1,9 @@
 ARG RUBY_VERSION
 FROM ruby:${RUBY_VERSION}-bullseye
 
+ADD https://github.com/fables-tales/rubyfmt/releases/download/v0.10.0/rubyfmt-v0.10.0-Linux-aarch64.tar.gz rubyfmt.tar.gz
+RUN tar -xzf rubyfmt.tar.gz && \
+    mv tmp/releases/v0.10.0-Linux/rubyfmt /usr/local/bin && \
+    rm -rf rubyfmt.tar.gz tmp
+
 WORKDIR /app

scripts/docker/Dockerfile.ruby

@@ -59,7 +59,8 @@ export async function formatter(language: string, cwd: string): Promise<void> {
       );
       break;
     case 'ruby':
-      await run('bundle install && bundle exec rubocop -a --fail-level W', { cwd, language });
+      await run('bundle install', { cwd, language });
+      await run('rubyfmt -i -- .', { cwd, language });
       break;
     case 'scala':
       await run('sbt -Dsbt.server.forcestart=true scalafmtAll scalafmtSbt', { cwd, language });

scripts/formatter.ts

@@ -5,4 +5,3 @@ source 'https://rubygems.org'
 gem 'algolia', path: '../../clients/algoliasearch-client-ruby'
 gem 'dotenv'
 gem 'rake'
-gem 'rubocop'