fix(go): true speed of benchmark

Author: millotp

.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -43,7 +43,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

config/clients.config.json

@@ -168,7 +168,6 @@
     "packageVersion": "5.5.2",
     "modelFolder": "model",
     "apiFolder": "src",
-    "dockerImage": "apic_base",
     "tests": {
       "extension": ".test.ts",
       "outputFolder": "src"

scripts/buildClients.ts

@@ -25,12 +25,12 @@ async function buildLanguage(language: Language, gens: Generator[], buildType: B
       await run('go build ./...', { cwd, language });
       break;
     case 'javascript':
-      await run('YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install', { cwd });
+      await run('YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install', { cwd, language });
       if (buildType === 'client') {
         const packageNames = gens.map(({ additionalProperties: { packageName } }) =>
           packageName === 'algoliasearch' ? packageName : `@algolia/${packageName}`,
         );
-        await run(`yarn build:many '{${packageNames.join(',')},}'`, { cwd });
+        await run(`yarn build:many '{${packageNames.join(',')},}'`, { cwd, language });
       }
 
       break;

scripts/cts/runCts.ts

@@ -57,10 +57,13 @@ async function runCtsOne(language: Language, suites: Record<CTSType, boolean>):
       });
       break;
     case 'go':
-      await run(`go test -race -count 1 ${isVerbose() ? '-v' : ''} ${filter((f) => `gotests/tests/${f}/...`)}`, {
-        cwd,
-        language,
-      });
+      await run(
+        `go test ${suites.benchmark ? '' : '-race'} -count 1 ${isVerbose() ? '-v' : ''} ${filter((f) => `gotests/tests/${f}/...`)}`,
+        {
+          cwd,
+          language,
+        },
+      );
       break;
     case 'java':
       await run(`./gradle/gradlew -p tests/output/java test --rerun ${filter((f) => `--tests 'com.algolia.${f}*'`)}`, {
@@ -70,6 +73,7 @@ async function runCtsOne(language: Language, suites: Record<CTSType, boolean>):
     case 'javascript':
       await run(`YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install && yarn test ${filter((f) => `src/${f}`)}`, {
         cwd,
+        language,
       });
       break;
     case 'kotlin':

scripts/cts/testServer/benchmark.ts

@@ -22,8 +22,9 @@ export function printBenchmarkReport(): void {
   const times: Array<{ lang: string; rate: number }> = [];
   for (const lang of Object.keys(benchmarkStatus)) {
     const status = benchmarkStatus[lang];
-    expect(status.requestTimes).to.have.length(1000);
-    const rate = 1000000 / (status.requestTimes.at(-1)! - status.requestTimes[0]);
+    expect(status.requestTimes).to.have.length(2000);
+    status.requestTimes.sort((a, b) => a - b);
+    const rate = (status.requestTimes.length * 1000) / (status.requestTimes.at(-1)! - status.requestTimes[0]);
     times.push({ lang, rate });
   }
 

scripts/formatter.ts

@@ -37,7 +37,7 @@ export async function formatter(language: string, cwd: string): Promise<void> {
       );
       break;
     case 'javascript':
-      await run(`yarn eslint --ext=ts,json ${cwd} --fix --no-error-on-unmatched-pattern`);
+      await run(`yarn eslint --ext=ts,json ${cwd} --fix --no-error-on-unmatched-pattern`, { language });
       break;
     case 'kotlin':
       await run(`./gradle/gradlew -p ${cwd} spotlessApply`, { language });

scripts/playground.ts

@@ -13,7 +13,7 @@ export async function playground({ language, client }: { language: AllLanguage;
       });
       break;
     case 'javascript':
-      await run(`yarn workspace javascript-playground start ${client}`);
+      await run(`yarn workspace javascript-playground start ${client}`, { language });
       break;
     case 'java':
       await run(

templates/Bug_report.yml

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

templates/go/tests/client/benchmark.mustache

@@ -14,22 +14,6 @@ import (
   "github.com/algolia/algoliasearch-client-go/v4/algolia/call"
 )
 
-func create{{#lambda.titlecase}}{{clientPrefix}}{{/lambda.titlecase}}Client(t *testing.T) (*{{clientPrefix}}.APIClient, *tests.EchoRequester) {
-  echo := &tests.EchoRequester{}
-  cfg := {{clientPrefix}}.{{clientName}}Configuration{
-    Configuration: transport.Configuration{
-      AppID:     "appID",
-      ApiKey:    "apiKey",
-      Requester: echo,
-    },{{#hasRegionalHost}}
-    Region:    {{clientPrefix}}.{{#lambda.uppercase}}{{defaultRegion}}{{/lambda.uppercase}},{{/hasRegionalHost}}
-  }
-  client, err := {{clientPrefix}}.NewClientWithConfig(cfg)
-  require.NoError(t, err)
-
-  return client, echo
-}
-
 {{#blocksBenchmark}}
 {{> tests/client/tests}}
 {{/blocksBenchmark}}

tests/CTS/benchmark/search/benchmark.json

@@ -19,7 +19,7 @@
       {
         "type": "method",
         "method": "search",
-        "times": 1000,
+        "times": 2000,
         "parameters": {
           "requests": [
             {