why swift

Author: millotp

scripts/cts/testServer/replaceAllObjects.ts

@@ -20,9 +20,10 @@ const raoState: Record<
 > = {};
 
 export function assertValidReplaceAllObjects(expectedCount: number): void {
-  const count = Object.values(raoState).filter((s) => s.successful && s.tmpIndexDeleted).length;
-  if (count !== expectedCount) {
-    throw new Error(`Expected ${expectedCount} call to replaceAllObjects, got ${count} instead.`);
+  expect(Object.keys(raoState)).to.have.length(expectedCount);
+  for (const lang in raoState) {
+    expect(raoState[lang].successful).to.equal(true);
+    expect(raoState[lang].tmpIndexDeleted).to.equal(true);
   }
 }
 

templates/go/search_helpers.mustache

@@ -657,47 +657,39 @@ func (c *APIClient) ReplaceAllObjects(indexName string, objects []map[string]any
 		return nil, err
 	}
 
+  defer func() {
+    _, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
+  }()
+
 	opts = append(opts, WithWaitForTasks(true))
 
 	batchResp, err := c.ChunkedBatch(tmpIndexName, objects, ACTION_ADD_OBJECT, opts...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}
 
 	_, err = c.WaitForTask(tmpIndexName, copyResp.TaskID, toIterableOptions(opts)...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}
 
 	copyResp, err = c.OperationIndex(c.NewApiOperationIndexRequest(indexName, NewOperationIndexParams(OPERATION_TYPE_COPY, tmpIndexName, WithOperationIndexParamsScope([]ScopeType{SCOPE_TYPE_SETTINGS, SCOPE_TYPE_RULES, SCOPE_TYPE_SYNONYMS}))), toRequestOptions(opts)...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}
 
 	_, err = c.WaitForTask(tmpIndexName, copyResp.TaskID, toIterableOptions(opts)...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}
 
 	moveResp, err := c.OperationIndex(c.NewApiOperationIndexRequest(tmpIndexName, NewOperationIndexParams(OPERATION_TYPE_MOVE, indexName)), toRequestOptions(opts)...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}
 
 	_, err = c.WaitForTask(tmpIndexName, moveResp.TaskID, toIterableOptions(opts)...)
 	if err != nil {
-		_, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName))
-
 		return nil, err
 	}