feat(javascript): add logger-console package from v4 (#3823)

Author: shortcuts

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.browser.test.ts

@@ -1,14 +1,35 @@
-import { test, expect } from 'vitest';
+/* eslint no-console: 0 */
 
-import { algoliasearch, apiClientVersion } from '../builds/browser';
+import { vi, test, expect } from 'vitest';
 
-const client = algoliasearch('APP_ID', 'API_KEY');
+import { LogLevelEnum } from '../../client-common/src/types';
+import { createConsoleLogger } from '../../logger-console/src/logger';
+import { algoliasearch, apiClientVersion } from '../builds/browser';
 
 test('sets the ua', () => {
+  const client = algoliasearch('APP_ID', 'API_KEY');
+
   expect(client.transporter.algoliaAgent).toEqual({
     add: expect.any(Function),
     value: expect.stringContaining(
       `Algolia for JavaScript (${apiClientVersion}); Search (${apiClientVersion}); Browser`,
     ),
   });
 });
+
+test('with logger', () => {
+  vi.spyOn(console, 'debug');
+  vi.spyOn(console, 'info');
+  vi.spyOn(console, 'error');
+
+  const client = algoliasearch('APP_ID', 'API_KEY', {
+    logger: createConsoleLogger(LogLevelEnum.Debug),
+  });
+
+  expect(async () => {
+    await client.setSettings({ indexName: 'foo', indexSettings: {} });
+    expect(console.debug).toHaveBeenCalledTimes(1);
+    expect(console.info).toHaveBeenCalledTimes(1);
+    expect(console.error).toHaveBeenCalledTimes(1);
+  }).not.toThrow();
+});

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.common.test.ts

@@ -103,6 +103,11 @@ describe('api', () => {
           url: 'APP_ID-2.algolianet.com',
         },
       ]),
+      logger: {
+        debug: expect.any(Function),
+        error: expect.any(Function),
+        info: expect.any(Function),
+      },
       hostsCache: {
         clear: expect.any(Function),
         delete: expect.any(Function),

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.fetch.test.ts

@@ -1,21 +1,42 @@
-import { test, expect } from 'vitest';
+/* eslint no-console: 0 */
 
-import { algoliasearch, apiClientVersion } from '../builds/fetch';
+import { vi, test, expect } from 'vitest';
 
-const client = algoliasearch('APP_ID', 'API_KEY');
+import { LogLevelEnum } from '../../client-common/src/types';
+import { createConsoleLogger } from '../../logger-console/src/logger';
+import { algoliasearch, apiClientVersion } from '../builds/fetch';
 
 test('sets the ua', () => {
+  const client = algoliasearch('APP_ID', 'API_KEY');
   expect(client.transporter.algoliaAgent).toEqual({
     add: expect.any(Function),
     value: expect.stringContaining(`Algolia for JavaScript (${apiClientVersion}); Search (${apiClientVersion}); Fetch`),
   });
 });
 
 test('forwards node search helpers', () => {
+  const client = algoliasearch('APP_ID', 'API_KEY');
   expect(client.generateSecuredApiKey).not.toBeUndefined();
   expect(client.getSecuredApiKeyRemainingValidity).not.toBeUndefined();
   expect(() => {
     const resp = client.generateSecuredApiKey({ parentApiKey: 'foo', restrictions: { validUntil: 200 } });
     client.getSecuredApiKeyRemainingValidity({ securedApiKey: resp });
   }).not.toThrow();
 });
+
+test('with logger', () => {
+  vi.spyOn(console, 'debug');
+  vi.spyOn(console, 'info');
+  vi.spyOn(console, 'error');
+
+  const client = algoliasearch('APP_ID', 'API_KEY', {
+    logger: createConsoleLogger(LogLevelEnum.Debug),
+  });
+
+  expect(async () => {
+    await client.setSettings({ indexName: 'foo', indexSettings: {} });
+    expect(console.debug).toHaveBeenCalledTimes(1);
+    expect(console.info).toHaveBeenCalledTimes(1);
+    expect(console.error).toHaveBeenCalledTimes(1);
+  }).not.toThrow();
+});

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.node.test.ts

@@ -1,10 +1,13 @@
-import { test, expect } from 'vitest';
+/* eslint no-console: 0 */
 
-import { algoliasearch, apiClientVersion } from '../builds/node';
+import { vi, test, expect } from 'vitest';
 
-const client = algoliasearch('APP_ID', 'API_KEY');
+import { LogLevelEnum } from '../../client-common/src/types';
+import { createConsoleLogger } from '../../logger-console/src/logger';
+import { algoliasearch, apiClientVersion } from '../builds/node';
 
 test('sets the ua', () => {
+  const client = algoliasearch('APP_ID', 'API_KEY');
   expect(client.transporter.algoliaAgent).toEqual({
     add: expect.any(Function),
     value: expect.stringContaining(
@@ -14,10 +17,28 @@ test('sets the ua', () => {
 });
 
 test('forwards node search helpers', () => {
+  const client = algoliasearch('APP_ID', 'API_KEY');
   expect(client.generateSecuredApiKey).not.toBeUndefined();
   expect(client.getSecuredApiKeyRemainingValidity).not.toBeUndefined();
   expect(() => {
     const resp = client.generateSecuredApiKey({ parentApiKey: 'foo', restrictions: { validUntil: 200 } });
     client.getSecuredApiKeyRemainingValidity({ securedApiKey: resp });
   }).not.toThrow();
 });
+
+test('with logger', () => {
+  vi.spyOn(console, 'debug');
+  vi.spyOn(console, 'info');
+  vi.spyOn(console, 'error');
+
+  const client = algoliasearch('APP_ID', 'API_KEY', {
+    logger: createConsoleLogger(LogLevelEnum.Debug),
+  });
+
+  expect(async () => {
+    await client.setSettings({ indexName: 'foo', indexSettings: {} });
+    expect(console.debug).toHaveBeenCalledTimes(1);
+    expect(console.info).toHaveBeenCalledTimes(1);
+    expect(console.error).toHaveBeenCalledTimes(1);
+  }).not.toThrow();
+});

clients/algoliasearch-client-javascript/packages/client-common/index.ts

@@ -1,8 +1,9 @@
-export * from './src/createAuth';
-export * from './src/createIterablePromise';
 export * from './src/cache';
-export * from './src/transporter';
+export * from './src/constants';
 export * from './src/createAlgoliaAgent';
+export * from './src/createAuth';
+export * from './src/createIterablePromise';
 export * from './src/getAlgoliaAgent';
+export * from './src/logger';
+export * from './src/transporter';
 export * from './src/types';
-export * from './src/constants';

clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/logger/null-logger.test.ts

@@ -0,0 +1,24 @@
+/* eslint no-console: 0 */
+
+import { vi, describe, test, expect } from 'vitest';
+
+import { createNullLogger } from '../../logger';
+
+describe('null logger', () => {
+  test('has a null behavior', async () => {
+    vi.resetAllMocks();
+    vi.spyOn(console, 'debug');
+    vi.spyOn(console, 'info');
+    vi.spyOn(console, 'error');
+
+    const logger = createNullLogger();
+
+    await logger.debug('foo', {});
+    await logger.info('foo', {});
+    await logger.error('foo', {});
+
+    expect(console.debug).toHaveBeenCalledTimes(0);
+    expect(console.info).toHaveBeenCalledTimes(0);
+    expect(console.error).toHaveBeenCalledTimes(0);
+  });
+});

clients/algoliasearch-client-javascript/packages/client-common/src/logger/createNullLogger.ts

@@ -0,0 +1,15 @@
+import type { Logger } from '../types/logger';
+
+export function createNullLogger(): Logger {
+  return {
+    debug(_message: string, _args?: any): Promise<void> {
+      return Promise.resolve();
+    },
+    info(_message: string, _args?: any): Promise<void> {
+      return Promise.resolve();
+    },
+    error(_message: string, _args?: any): Promise<void> {
+      return Promise.resolve();
+    },
+  };
+}

clients/algoliasearch-client-javascript/packages/client-common/src/logger/index.ts

@@ -0,0 +1 @@
+export * from './createNullLogger';

clients/algoliasearch-client-javascript/packages/client-common/src/transporter/createTransporter.ts

@@ -25,6 +25,7 @@ export function createTransporter({
   hosts,
   hostsCache,
   baseHeaders,
+  logger,
   baseQueryParameters,
   algoliaAgent,
   timeouts,
@@ -174,8 +175,7 @@ export function createTransporter({
          * the end user to debug / store stack frames even
          * when a retry error does not happen.
          */
-        // eslint-disable-next-line no-console -- this will be fixed by exposing a `logger` to the transporter
-        console.log('Retryable failure', stackFrameWithoutCredentials(stackFrame));
+        logger.info('Retryable failure', stackFrameWithoutCredentials(stackFrame));
 
         /**
          * We also store the state of the host in failure cases. If the host, is
@@ -304,6 +304,7 @@ export function createTransporter({
     hostsCache,
     requester,
     timeouts,
+    logger,
     algoliaAgent,
     baseHeaders,
     baseQueryParameters,

clients/algoliasearch-client-javascript/packages/client-common/src/types/index.ts

@@ -2,5 +2,6 @@ export * from './cache';
 export * from './createClient';
 export * from './createIterablePromise';
 export * from './host';
+export * from './logger';
 export * from './requester';
 export * from './transporter';