chore: review

Author: shortcuts

scripts/cts/testServer/replaceAllObjectsWithTransformation.ts

@@ -6,7 +6,7 @@ import express from 'express';
 
 import { setupServer } from './index.ts';
 
-const raoState: Record<
+const raowtState: Record<
   string,
   {
     copyCount: number;
@@ -19,9 +19,9 @@ const raoState: Record<
 > = {};
 
 export function assertValidReplaceAllObjectsWithTransformation(expectedCount: number): void {
-  expect(Object.keys(raoState)).to.have.length(expectedCount);
-  for (const lang in raoState) {
-    expect(raoState[lang].successful).to.equal(true);
+  expect(Object.keys(raowtState)).to.have.length(expectedCount);
+  for (const lang in raowtState) {
+    expect(raowtState[lang].successful).to.equal(true);
   }
 }
 
@@ -43,8 +43,8 @@ function addRoutes(app: Express): void {
         expect(req.body.scope).to.deep.equal(['settings', 'rules', 'synonyms']);
 
         const lang = req.params.indexName.replace('cts_e2e_replace_all_objects_with_transformation_', '');
-        if (!raoState[lang] || raoState[lang].successful) {
-          raoState[lang] = {
+        if (!raowtState[lang] || raowtState[lang].successful) {
+          raowtState[lang] = {
             copyCount: 1,
             pushCount: 0,
             waitTaskCount: 0,
@@ -53,16 +53,16 @@ function addRoutes(app: Express): void {
             successful: false,
           };
         } else {
-          raoState[lang].copyCount++;
+          raowtState[lang].copyCount++;
         }
 
-        res.json({ taskID: 123 + raoState[lang].copyCount, updatedAt: '2021-01-01T00:00:00.000Z' });
+        res.json({ taskID: 123 + raowtState[lang].copyCount, updatedAt: '2021-01-01T00:00:00.000Z' });
         break;
       }
       case 'move': {
         const lang = req.body.destination.replace('cts_e2e_replace_all_objects_with_transformation_', '');
-        expect(raoState).to.include.keys(lang);
-        expect(raoState[lang]).to.deep.equal({
+        expect(raowtState).to.include.keys(lang);
+        expect(raowtState[lang]).to.deep.equal({
           copyCount: 2,
           pushCount: 10,
           waitTaskCount: 2,
@@ -73,7 +73,7 @@ function addRoutes(app: Express): void {
 
         expect(req.body.scope).to.equal(undefined);
 
-        raoState[lang].waitingForFinalWaitTask = true;
+        raowtState[lang].waitingForFinalWaitTask = true;
 
         res.json({ taskID: 777, updatedAt: '2021-01-01T00:00:00.000Z' });
 
@@ -90,14 +90,14 @@ function addRoutes(app: Express): void {
     const lang = req.params.indexName.match(
       /^cts_e2e_replace_all_objects_with_transformation_(.*)_tmp_\d+$/,
     )?.[1] as string;
-    expect(raoState).to.include.keys(lang);
+    expect(raowtState).to.include.keys(lang);
     expect(req.body.action === 'addObject').to.equal(true);
 
-    raoState[lang].pushCount += req.body.records.length;
+    raowtState[lang].pushCount += req.body.records.length;
 
     res.json({
       runID: 'b1b7a982-524c-40d2-bb7f-48aab075abda',
-      eventID: `113b2068-6337-4c85-b5c2-e7b213d8292${raoState[lang].pushCount}`,
+      eventID: `113b2068-6337-4c85-b5c2-e7b213d8292${raowtState[lang].pushCount}`,
       message: 'OK',
       createdAt: '2022-05-12T06:24:30.049Z',
     });
@@ -111,14 +111,14 @@ function addRoutes(app: Express): void {
     const lang = req.params.indexName.match(
       /^cts_e2e_replace_all_objects_with_transformation_(.*)_tmp_\d+$/,
     )?.[1] as string;
-    expect(raoState).to.include.keys(lang);
+    expect(raowtState).to.include.keys(lang);
 
-    raoState[lang].waitTaskCount++;
-    if (raoState[lang].waitingForFinalWaitTask) {
+    raowtState[lang].waitTaskCount++;
+    if (raowtState[lang].waitingForFinalWaitTask) {
       expect(req.params.taskID).to.equal('777');
-      expect(raoState[lang].waitTaskCount).to.equal(3);
+      expect(raowtState[lang].waitTaskCount).to.equal(3);
 
-      raoState[lang].successful = true;
+      raowtState[lang].successful = true;
     }
 
     res.json({ status: 'published', updatedAt: '2021-01-01T00:00:00.000Z' });

templates/javascript/clients/algoliasearch/builds/definition.mustache

@@ -86,7 +86,7 @@ export type Algoliasearch = SearchClient & {
    * @param chunkedPush.action - The `batch` `action` to perform on the given array of `objects`, defaults to `addObject`.
    * @param chunkedPush.waitForTasks - Whether or not we should wait until every `batch` tasks has been processed, this operation may slow the total execution time of this method but is more reliable.
    * @param chunkedPush.batchSize - The size of the chunk of `objects`. The number of `batch` calls will be equal to `length(objects) / batchSize`. Defaults to 1000.
-   * @param requestOptions - The requestOptions to send along with the query, they will be forwarded to the `getTask` method and merged with the transporter requestOptions.
+   * @param requestOptions - The requestOptions to send along with the query, they will be forwarded to the `getEvent` method and merged with the transporter requestOptions.
    */
   chunkedPush: (options: ChunkedBatchOptions, requestOptions?: RequestOptions) => Promise<Array<WatchResponse>>;
 };
@@ -207,7 +207,7 @@ export function algoliasearch(
 
       if (waitForTasks) {
         for (const resp of responses) {
-          if (resp.eventID === undefined || !resp.eventID) {
+          if (!resp.eventID) {
             throw new Error('received unexpected response from the push endpoint, eventID must not be undefined');
           }
 
@@ -231,7 +231,7 @@ export function algoliasearch(
               validate: () => retryCount >= 50,
               message: () => `The maximum number of retries exceeded. (${retryCount}/${50})`,
             },
-            timeout: (): number => Math.min(retryCount * 200, 5000),
+            timeout: (): number => Math.min(retryCount * 500, 5000),
           });
         }
       }