chore: enforce common pkgs as well

Author: shortcuts

clients/algoliasearch-client-javascript/packages/logger-console/src/logger.ts

@@ -3,23 +3,23 @@ import { LogLevelEnum } from '@algolia/client-common';
 
 export function createConsoleLogger(logLevel: LogLevelType): Logger {
   return {
-    debug(message: string, args?: any): Readonly<Promise<void>> {
+    debug(message: string, args?: any | undefined): Readonly<Promise<void>> {
       if (LogLevelEnum.Debug >= logLevel) {
         console.debug(message, args);
       }
 
       return Promise.resolve();
     },
 
-    info(message: string, args?: any): Readonly<Promise<void>> {
+    info(message: string, args?: any | undefined): Readonly<Promise<void>> {
       if (LogLevelEnum.Info >= logLevel) {
         console.info(message, args);
       }
 
       return Promise.resolve();
     },
 
-    error(message: string, args?: any): Readonly<Promise<void>> {
+    error(message: string, args?: any | undefined): Readonly<Promise<void>> {
       console.error(message, args);
 
       return Promise.resolve();

clients/algoliasearch-client-javascript/packages/requester-fetch/src/createFetchRequester.ts

@@ -12,7 +12,7 @@ function getErrorMessage(error: unknown, abortContent: string): string {
 }
 
 export type FetchRequesterOptions = {
-  readonly requesterOptions?: RequestInit;
+  readonly requesterOptions?: RequestInit | undefined;
 };
 
 export function createFetchRequester({ requesterOptions = {} }: FetchRequesterOptions = {}): Requester {

clients/algoliasearch-client-javascript/packages/requester-testing/src/createEchoRequester.ts

@@ -4,7 +4,7 @@ export type EchoResponse = Omit<EndRequest, 'data'> &
   Pick<Request, 'data' | 'path'> & {
     host: string;
     algoliaAgent: string;
-    searchParams?: Record<string, string>;
+    searchParams?: Record<string, string> | undefined;
   };
 
 type BasicURL = {
@@ -15,7 +15,7 @@ type BasicURL = {
 
 export type EchoRequesterParams = {
   getURL: (url: string) => BasicURL;
-  status?: number;
+  status?: number | undefined;
 };
 
 function getUrlParams({

clients/algoliasearch-client-javascript/tsconfig.json

@@ -1,24 +1,25 @@
 {
   "compilerOptions": {
     "allowJs": false,
-    "verbatimModuleSyntax": true,
     "allowSyntheticDefaultImports": true,
     "declaration": true,
     "esModuleInterop": true,
+    "exactOptionalPropertyTypes": true,
     "lib": ["dom", "esnext", "dom.iterable", "scripthost"],
     "module": "esnext",
     "moduleResolution": "node",
     "noImplicitAny": true,
-    "noImplicitThis": true,
     "noImplicitOverride": true,
+    "noImplicitThis": true,
     "noLib": false,
     "noUnusedLocals": true,
     "outDir": "dist",
     "removeComments": false,
     "sourceMap": true,
     "strict": true,
     "target": "esnext",
-    "types": ["node"]
+    "types": ["node"],
+    "verbatimModuleSyntax": true
   },
   "include": ["packages/**/*.ts"],
   "exclude": ["dist", "node_modules"]

templates/javascript/clients/tsconfig.mustache

@@ -4,8 +4,7 @@
     {{#isAlgoliasearchClient}}
     "types": ["node", "@cloudflare/workers-types", "@cloudflare/vitest-pool-workers", "vitest/globals"],
     {{/isAlgoliasearchClient}}
-    "outDir": "dist",
-    "exactOptionalPropertyTypes": true
+    "outDir": "dist"
   },
   "include": ["{{apiPackage}}", "model", "builds"],
   "exclude": ["dist", "node_modules"]