fix(specs): abtest v3 naming conflict with Metric type (#5090)

Co-authored-by: Clément Vannicatte <[email protected]>

Author: cdhawke

specs/abtesting-v3/common/parameters.yml

@@ -138,7 +138,7 @@ filterEffects:
           description: Number of tracked searches removed from the A/B test.
           example: 237
 
-metric:
+createMetric:
   type: object
   description: Defines a metric to be retrieved during an A/B test.
   properties:

specs/abtesting-v3/common/schemas/Timeseries.yml

@@ -42,7 +42,7 @@ metricDate:
     metrics:
       $ref: 'Variant.yml#/metrics'
 
-Metric:
+MetricName:
   type: string
   enum:
     - search_count

specs/abtesting-v3/common/schemas/Variant.yml

@@ -40,9 +40,9 @@ metrics:
   type: array
   description: All ABTest metrics that were defined during test creation.
   items:
-    $ref: '#/metric'
+    $ref: '#/metricResult'
 
-metric:
+metricResult:
   type: object
   properties:
     name:

specs/abtesting-v3/paths/abtests.yml

@@ -25,9 +25,9 @@ post:
                 $ref: '../common/schemas/AddABTestsVariant.yml#/AddABTestsVariant'
             metrics:
               type: array
-              description: A/B test metrics involved in the test. Only these metrics will be considered when calculating results. 
+              description: A/B test metrics involved in the test. Only these metrics will be considered when calculating results.
               items:
-                $ref: '../common/parameters.yml#/metric'
+                $ref: '../common/parameters.yml#/createMetric'
             configuration:
               $ref: '../common/schemas/ABTest.yml#/ABTestConfiguration'
             endAt:

specs/abtesting-v3/paths/scheduleABTest.yml

@@ -28,7 +28,7 @@ post:
               type: array
               description: A/B test metrics involved in the test. Only these metrics will be considered when calculating results.
               items:
-                $ref: '../common/parameters.yml#/metric'
+                $ref: '../common/parameters.yml#/createMetric'
             configuration:
               $ref: '../common/schemas/ABTest.yml#/ABTestConfiguration'
             scheduledAt:

specs/abtesting-v3/paths/timeseries.yml

@@ -16,7 +16,7 @@ get:
       schema:
         type: array
         items:
-          $ref: '../common/schemas/Timeseries.yml#/Metric'
+          $ref: '../common/schemas/Timeseries.yml#/MetricName'
   responses:
     '200':
       description: OK