fix nullable in go and remove test

Author: millotp

clients/algoliasearch-client-go/algolia/utils/utils.go

@@ -26,7 +26,7 @@ func (v Nullable[T]) Get() *T {
 
 func (v *Nullable[T]) Set(val *T) {
 	v.value = val
-	v.isSet = true
+	v.isSet = val != nil
 }
 
 func (v Nullable[T]) IsSet() bool {
@@ -39,16 +39,18 @@ func (v *Nullable[T]) Unset() {
 }
 
 func NewNullable[T any](val *T) *Nullable[T] {
-	return &Nullable[T]{value: val, isSet: true}
+	return &Nullable[T]{value: val, isSet: val != nil}
 }
 
 func (v Nullable[T]) MarshalJSON() ([]byte, error) {
 	return json.Marshal(v.value)
 }
 
 func (v *Nullable[T]) UnmarshalJSON(src []byte) error {
-	v.isSet = true
-	return json.Unmarshal(src, &v.value)
+	err := json.Unmarshal(src, &v.value)
+	v.isSet = v.value != nil
+
+	return err
 }
 
 // IsNilOrEmpty checks if an input is nil or empty.

scripts/cts/testServer/algoliaMock.ts

@@ -37,18 +37,6 @@ function addRoutes(app: Express): void {
       processingTimeMS: 0,
     });
   });
-
-  app.get('/1/runs/:runID/events/:eventID', (req, res) => {
-    res.json({
-      eventID: req.params.eventID,
-      runID: req.params.runID,
-      status: null,
-      type: 'log',
-      batchSize: 100,
-      data: null,
-      publishedAt: '2023-10-03T12:00:00Z',
-    });
-  });
 }
 
 export function algoliaMockServer(): Promise<Server> {

specs/ingestion/common/schemas/source.yml

@@ -352,7 +352,7 @@ SourceDocker:
   properties:
     image:
       type: string
-      description: Shortname of the image, as returned by the referential.
+      description: Name of the connector.
       example: zendesk
     configuration:
       type: object

templates/go/model_simple.mustache

@@ -274,16 +274,26 @@ func (o {{classname}}) MarshalJSON() ([]byte, error) {
 	}
 	{{/vendorExtensions.x-golang-is-container}}
 	{{^vendorExtensions.x-golang-is-container}}
-	if {{#required}}true{{/required}}{{^required}}o.{{name}}.IsSet(){{/required}} {
+  {{#required}}
+  toSerialize["{{baseName}}"] = o.{{name}}.Get()
+  {{/required}}
+  {{^required}}
+  if o.{{name}}.IsSet() {
 		toSerialize["{{baseName}}"] = o.{{name}}.Get()
 	}
+  {{/required}}
 	{{/vendorExtensions.x-golang-is-container}}
 	{{/isNullable}}
 	{{! if argument is not nullable, don't set it if it is nil}}
 	{{^isNullable}}
-	if {{#required}}true{{/required}}{{^required}}o.{{name}} != nil{{/required}} {
+  {{#required}}
+  toSerialize["{{baseName}}"] = o.{{name}}
+  {{/required}}
+  {{^required}}
+  if o.{{name}} != nil {
 		toSerialize["{{baseName}}"] = o.{{name}}
 	}
+  {{/required}}
 	{{/isNullable}}
 	{{/vars}}
 	{{#isAdditionalPropertiesTrue}}
@@ -443,4 +453,4 @@ func (o {{classname}}) String() string {
 	}
 	{{/isAdditionalPropertiesTrue}}
   return fmt.Sprintf("{{classname}} {\n%s}", out)
-}
+}