Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Sep 17, 2024

🧭 What and Why

Node has been adding a lot of cool feature that renders other packages useless, in this PR I migrate dotenv and jest for the CTS.

@millotp millotp requested a review from a team as a code owner September 17, 2024 07:13
@millotp millotp requested review from Fluf22 and shortcuts September 17, 2024 07:13
@millotp millotp self-assigned this Sep 17, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 17, 2024

✔️ Code generated!

Name Link
🪓 Triggered by e3e2bdc01bd59867ba9fb7af7d2554b2e18dc2cb
🍃 Generated commit 485e7a0abf72bc50458a46ed79b4ef029071e07f
🌲 Generated branch generated/fix/no-more-jest
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1754
php 1526
csharp 1225
python 1086
java 970
ruby 869
swift 751
go 573

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soooo nice

@millotp millotp requested a review from shortcuts September 17, 2024 09:02
@shortcuts shortcuts changed the title fix(cts): use node test runner instead of jest fix(cts): use vitest instead of jest Sep 17, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice!!! it will also help me when adding the browser cts test, thanks!

@millotp millotp merged commit 57cab61 into main Sep 17, 2024
@millotp millotp deleted the fix/no-more-jest branch September 17, 2024 09:44
algolia-bot added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants