Skip to content

Conversation

@shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 15, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3071

Changes included:

this pr fixes some of the issues identified in the client testing from @kombucha

@shortcuts shortcuts self-assigned this Oct 15, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 1df07fb5bafa6940d00f8644ea963b7373983b95
🍃 Generated commit 4acaeec9efe8ab0e76a2a5967d04e4cd66b9a632
🌲 Generated branch generated/fix/specs-vinnie-review
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1682
go 1643
php 1484
csharp 1395
java 1148
python 1051
ruby 922
swift 692

@shortcuts shortcuts marked this pull request as ready for review October 15, 2024 14:48
@shortcuts shortcuts requested a review from a team as a code owner October 15, 2024 14:48
Fluf22
Fluf22 previously approved these changes Oct 15, 2024
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ref: '../../../../common/responses/common.yml#/createdAtTimestamp'
required:
- key
- value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that redocly doesn't warn about that, I'm sure we have the same somewhere else

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was shocked too idk how it went through?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually there are some warnings like Component: "attributeToUpdate" is never used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah in the warnings we silence? I'll check that

@shortcuts shortcuts requested review from Fluf22 and millotp October 16, 2024 12:49
@shortcuts shortcuts enabled auto-merge (squash) October 16, 2024 12:55
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@shortcuts shortcuts merged commit 519fd98 into main Oct 16, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/specs-vinnie-review branch October 16, 2024 13:20
algolia-bot added a commit that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 16, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants