Skip to content

fix(specs): drop singer from ingestion specs [skip-bc] #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(specs): drop singer from ingestion specs [skip-bc] #4281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6762eb2
fix(specs): drop singer from ingestion specs
shortcuts Dec 23, 2024
2731992
Merge branch 'main' into fix/ingestion-drop-singer
shortcuts Dec 23, 2024
abdcb77
Merge branch 'main' into fix/ingestion-drop-singer
shortcuts Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/ingestion/common/schemas/source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ DockerRegistry:

DockerImageType:
type: string
enum: [singer, custom, airbyte]
enum: [custom, airbyte]
description: Image type.

SourceInput:
Expand Down
2 changes: 1 addition & 1 deletion specs/ingestion/common/schemas/task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ StreamingInput:
- mapping

DockerStreamsInput:
description: The selected streams of a singer or airbyte connector.
description: The selected streams of an airbyte connector.
type: object
properties:
streams:
Expand Down
2 changes: 1 addition & 1 deletion specs/ingestion/paths/sources/discover.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ post:
summary: Trigger a stream-listing request
description: |
Triggers a stream-listing request for a source.
Triggering stream-listing requests only works with sources with `type: docker` and `imageType: singer`.
Triggering stream-listing requests only works with sources with `type: docker` and `imageType: airbyte`.
operationId: triggerDockerSourceDiscover
x-acl:
- addObject
Expand Down