fix(java): saveObjects always passing waitForTasks as false #4460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algolia-bot
added a commit
that referenced
this pull request
Feb 15, 2025
…generated) [skip ci] Co-authored-by: Migliorin Francesco Antonio <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Feb 15, 2025
algolia/api-clients-automation#4460 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Migliorin Francesco Antonio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The
com.algolia.api.SearchClient#saveObjects(String, Iterable, boolean, RequestOptions)method takes thewaitForTasksparameter, but it is ignored and always set tofalse.🎟 JIRA Ticket:
Changes included:
waitForTasksparameter instead of hardcodingfalse🧪 Test