From e96f86b65cc31999749ce41a39a6d23de5a756c9 Mon Sep 17 00:00:00 2001
From: Lucas Aragno <lucas@iheartjane.com>
Date: Wed, 2 Apr 2025 12:08:00 -0300
Subject: [PATCH 1/2] fix(ruby): remove integer empty check

---
 .../lib/algolia/api/abtesting_client.rb                     | 6 +++---
 .../lib/algolia/api/analytics_client.rb                     | 6 +++---
 .../lib/algolia/api/composition_client.rb                   | 6 +++---
 .../lib/algolia/api/ingestion_client.rb                     | 6 +++---
 .../lib/algolia/api/insights_client.rb                      | 6 +++---
 .../lib/algolia/api/monitoring_client.rb                    | 6 +++---
 .../lib/algolia/api/personalization_client.rb               | 6 +++---
 .../lib/algolia/api/query_suggestions_client.rb             | 6 +++---
 .../lib/algolia/api/recommend_client.rb                     | 6 +++---
 .../lib/algolia/api/search_client.rb                        | 6 +++---
 templates/ruby/api.mustache                                 | 6 +++---
 11 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
index 66a4907e27c..91729322f5e 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
index df26ab73f39..5f878ec7ee3 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
index a4e029853f4..a13e96001b1 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
@@ -31,15 +31,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
index eaf54380fd8..cdb92b59bb9 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 25000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 25000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 25000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
index a7125f9d8bb..eccf95c64aa 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
index aaa34d9b02a..6f23cdac51b 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
@@ -23,15 +23,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
index 860721bfbff..ffce871b730 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
index b2e3bc4e940..e375605caa1 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
index 2ffaa750b0a..088418a0373 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
@@ -31,15 +31,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
index 66528a5cd2f..bed41b27fa4 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
@@ -34,15 +34,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? || config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = 30000
       end
 
diff --git a/templates/ruby/api.mustache b/templates/ruby/api.mustache
index f56a9191268..7ed75fcd89a 100644
--- a/templates/ruby/api.mustache
+++ b/templates/ruby/api.mustache
@@ -58,15 +58,15 @@ module {{moduleName}}
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil? ||config.connect_timeout.empty?
+      if config.connect_timeout.nil?
         config.connect_timeout = {{x-timeouts.server.connect}}
       end
 
-      if config.read_timeout.nil? || config.read_timeout.empty?
+      if config.read_timeout.nil?
         config.read_timeout = {{x-timeouts.server.read}}
       end
 
-      if config.write_timeout.nil? || config.write_timeout.empty?
+      if config.write_timeout.nil?
         config.write_timeout = {{x-timeouts.server.write}}
       end
 

From cf43eaf36f6befbd551e1d6210386199ca42b603 Mon Sep 17 00:00:00 2001
From: Lucas Aragno <lucas@iheartjane.com>
Date: Wed, 2 Apr 2025 12:28:45 -0300
Subject: [PATCH 2/2] fix(ruby): remove empty check from integer

---
 .../lib/algolia/api/abtesting_client.rb                     | 6 +++---
 .../lib/algolia/api/analytics_client.rb                     | 6 +++---
 .../lib/algolia/api/composition_client.rb                   | 6 +++---
 .../lib/algolia/api/ingestion_client.rb                     | 6 +++---
 .../lib/algolia/api/insights_client.rb                      | 6 +++---
 .../lib/algolia/api/monitoring_client.rb                    | 6 +++---
 .../lib/algolia/api/personalization_client.rb               | 6 +++---
 .../lib/algolia/api/query_suggestions_client.rb             | 6 +++---
 .../lib/algolia/api/recommend_client.rb                     | 6 +++---
 .../lib/algolia/api/search_client.rb                        | 6 +++---
 10 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
index 91729322f5e..66a4907e27c 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/abtesting_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
index 5f878ec7ee3..df26ab73f39 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/analytics_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
index a13e96001b1..a4e029853f4 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/composition_client.rb
@@ -31,15 +31,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
index cdb92b59bb9..eaf54380fd8 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/ingestion_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 25000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 25000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 25000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
index eccf95c64aa..a7125f9d8bb 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/insights_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
index 6f23cdac51b..aaa34d9b02a 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/monitoring_client.rb
@@ -23,15 +23,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
index ffce871b730..860721bfbff 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/personalization_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
index e375605caa1..b2e3bc4e940 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/query_suggestions_client.rb
@@ -38,15 +38,15 @@ def self.create(app_id, api_key, region = nil, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
index 088418a0373..2ffaa750b0a 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/recommend_client.rb
@@ -31,15 +31,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end
 
diff --git a/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb b/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
index bed41b27fa4..66528a5cd2f 100644
--- a/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
+++ b/clients/algoliasearch-client-ruby/lib/algolia/api/search_client.rb
@@ -34,15 +34,15 @@ def self.create(app_id, api_key, opts = {})
     end
 
     def self.create_with_config(config)
-      if config.connect_timeout.nil?
+      if config.connect_timeout.nil? || config.connect_timeout.empty?
         config.connect_timeout = 2000
       end
 
-      if config.read_timeout.nil?
+      if config.read_timeout.nil? || config.read_timeout.empty?
         config.read_timeout = 5000
       end
 
-      if config.write_timeout.nil?
+      if config.write_timeout.nil? || config.write_timeout.empty?
         config.write_timeout = 30000
       end