Skip to content

fix(swift): retry strategy + cts test #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(swift): retry strategy + cts test #5654

wants to merge 5 commits into from
+134 −3

Conversation

@Fluf22
Copy link
Collaborator

@Fluf22 Fluf22 commented Nov 21, 2025 •
edited by atlassian bot
Loading

🧭 What and Why

🎟 JIRA Ticket: CR-9944

Changes included:

  • prevent Swift retry strat to change host when req is 2xx
  • test retry strat happy path in CTS

🧪 Test

@Fluf22 Fluf22 requested a review from a team as a code owner November 21, 2025 15:45
@Fluf22 Fluf22 self-assigned this Nov 21, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 21, 2025 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by b49acdb4392b1a05cb8c8fe44b2e4f1e74afe396
🍃 Generated commit 3aa9d91619bd5123679580e6bd3fad093a3b1056
🌲 Generated branch generated/fix/swift-retry-strategy
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2475
go 2296
php 1998
python 1355
csharp 1340
java 1180
ruby 921
swift 389
scala 23

@Fluf22 Fluf22 changed the title fix/swift-retry-strategy fix(swift): retry strategy + cts test Nov 21, 2025
@Fluf22 Fluf22 requested a review from shortcuts November 21, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts

At least 1 approving review is required to merge this pull request.

Assignees

@Fluf22 Fluf22

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fluf22 @algolia-bot