refactor(core): extract Navigator to allow testing

Author: francoischalifour

packages/autocomplete-core/src/getDefaultProps.ts

@@ -1,3 +1,4 @@
+import { getNavigator } from './getNavigator';
 import { InternalAutocompleteOptions, AutocompleteOptions } from './types';
 import {
   generateAutocompleteId,
@@ -9,7 +10,9 @@ import {
 export function getDefaultProps<TItem>(
   props: AutocompleteOptions<TItem>
 ): InternalAutocompleteOptions<TItem> {
-  const environment: typeof window = (typeof window !== 'undefined'
+  const environment: InternalAutocompleteOptions<
+    unknown
+  >['environment'] = (typeof window !== 'undefined'
     ? window
     : {}) as typeof window;
   const plugins = props.plugins || [];
@@ -38,6 +41,7 @@ export function getDefaultProps<TItem>(
       context: {},
       ...props.initialState,
     },
+    plugins,
     onStateChange(params) {
       props.onStateChange?.(params);
       plugins.forEach((plugin) => {
@@ -70,21 +74,8 @@ export function getDefaultProps<TItem>(
         );
     },
     navigator: {
-      navigate({ itemUrl }) {
-        environment.location.assign(itemUrl);
-      },
-      navigateNewTab({ itemUrl }) {
-        const windowReference = environment.open(itemUrl, '_blank', 'noopener');
-
-        if (windowReference) {
-          windowReference.focus();
-        }
-      },
-      navigateNewWindow({ itemUrl }) {
-        environment.open(itemUrl, '_blank', 'noopener');
-      },
+      ...getNavigator({ environment }),
       ...props.navigator,
     },
-    plugins,
   };
 }

packages/autocomplete-core/src/getNavigator.ts

@@ -0,0 +1,24 @@
+import { InternalAutocompleteOptions } from './types';
+
+export function getNavigator({
+  environment,
+}: Pick<
+  InternalAutocompleteOptions<unknown>,
+  'environment'
+>): InternalAutocompleteOptions<unknown>['navigator'] {
+  return {
+    navigate({ itemUrl }) {
+      environment.location.assign(itemUrl);
+    },
+    navigateNewTab({ itemUrl }) {
+      const windowReference = environment.open(itemUrl, '_blank', 'noopener');
+
+      if (windowReference) {
+        windowReference.focus();
+      }
+    },
+    navigateNewWindow({ itemUrl }) {
+      environment.open(itemUrl, '_blank', 'noopener');
+    },
+  };
+}