Skip to content

Commit 1c1b951

Browse files
francoischalifourfrancoischalifour
committed
feat(core): rename highlight to active
BREAKING CHANGE
1 parent a52241c commit 1c1b951

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+258
-260
lines changed

‎examples/react-renderer/src/Autocomplete.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function Autocomplete(
3636
context: {},
3737
isOpen: false,
3838
query: '',
39-
selectedItemId: null,
39+
activeItemId: null,
4040
status: 'idle',
4141
});
4242
const autocomplete = React.useMemo(

‎packages/autocomplete-core/src/__tests__/completion.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe('completion', () => {
8282
});
8383
});
8484

85-
test('does not set completion when no selectedItemId', () => {
85+
test('does not set completion when no activeItemId', () => {
8686
const onStateChange = jest.fn();
8787
const { inputElement } = createPlayground(createAutocomplete, {
8888
openOnFocus: true,

‎packages/autocomplete-core/src/__tests__/createAutocomplete.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('createAutocomplete', () => {
1818
setContext: expect.any(Function),
1919
setIsOpen: expect.any(Function),
2020
setQuery: expect.any(Function),
21-
setSelectedItemId: expect.any(Function),
21+
setActiveItemId: expect.any(Function),
2222
setStatus: expect.any(Function),
2323
});
2424
});
@@ -29,13 +29,13 @@ describe('createAutocomplete', () => {
2929

3030
expect(plugin.subscribe).toHaveBeenCalledTimes(1);
3131
expect(plugin.subscribe).toHaveBeenLastCalledWith({
32-
onHighlight: expect.any(Function),
32+
onActive: expect.any(Function),
3333
onSelect: expect.any(Function),
3434
setCollections: expect.any(Function),
3535
setContext: expect.any(Function),
3636
setIsOpen: expect.any(Function),
3737
setQuery: expect.any(Function),
38-
setSelectedItemId: expect.any(Function),
38+
setActiveItemId: expect.any(Function),
3939
setStatus: expect.any(Function),
4040
});
4141
});

‎packages/autocomplete-core/src/__tests__/defaultSelectedItemId.test.ts‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import userEvent from '@testing-library/user-event';
22

33
import { createAutocomplete } from '../createAutocomplete';
44

5-
describe('defaultSelectedItemId', () => {
6-
test('selects unset defaultSelectedItemId on open (onInput)', () => {
5+
describe('defaultActiveItemId', () => {
6+
test('selects unset defaultActiveItemId on open (onInput)', () => {
77
const onStateChange = jest.fn();
88
const autocomplete = createAutocomplete({
99
openOnFocus: true,
@@ -20,17 +20,17 @@ describe('defaultSelectedItemId', () => {
2020
expect(onStateChange).toHaveBeenLastCalledWith({
2121
prevState: expect.anything(),
2222
state: expect.objectContaining({
23-
selectedItemId: null,
23+
activeItemId: null,
2424
}),
2525
});
2626
});
2727

28-
test('selects provided defaultSelectedItemId on open (onInput)', () => {
28+
test('selects provided defaultActiveItemId on open (onInput)', () => {
2929
const onStateChange = jest.fn();
3030
const autocomplete = createAutocomplete({
3131
openOnFocus: true,
3232
onStateChange,
33-
defaultSelectedItemId: 0,
33+
defaultActiveItemId: 0,
3434
});
3535
const inputElement = document.createElement('input');
3636
const inputProps = autocomplete.getInputProps({ inputElement });
@@ -42,17 +42,17 @@ describe('defaultSelectedItemId', () => {
4242
expect(onStateChange).toHaveBeenLastCalledWith({
4343
prevState: expect.anything(),
4444
state: expect.objectContaining({
45-
selectedItemId: 0,
45+
activeItemId: 0,
4646
}),
4747
});
4848
});
4949

50-
test('selects defaultSelectedItemId with openOnFocus on reset', () => {
50+
test('selects defaultActiveItemId with openOnFocus on reset', () => {
5151
const onStateChange = jest.fn();
5252
const autocomplete = createAutocomplete({
5353
openOnFocus: true,
5454
onStateChange,
55-
defaultSelectedItemId: 0,
55+
defaultActiveItemId: 0,
5656
});
5757
const formElement = document.createElement('form');
5858
const inputElement = document.createElement('input');
@@ -63,23 +63,23 @@ describe('defaultSelectedItemId', () => {
6363
document.body.appendChild(formElement);
6464
formElement.appendChild(inputElement);
6565

66-
autocomplete.setSelectedItemId(null);
66+
autocomplete.setActiveItemId(null);
6767
formElement.reset();
6868

6969
expect(onStateChange).toHaveBeenLastCalledWith({
7070
prevState: expect.anything(),
7171
state: expect.objectContaining({
72-
selectedItemId: 0,
72+
activeItemId: 0,
7373
}),
7474
});
7575
});
7676

77-
test('selects defaultSelectedItemId on focus', () => {
77+
test('selects defaultActiveItemId on focus', () => {
7878
const onStateChange = jest.fn();
7979
const { getInputProps } = createAutocomplete({
8080
openOnFocus: true,
8181
onStateChange,
82-
defaultSelectedItemId: 0,
82+
defaultActiveItemId: 0,
8383
});
8484
const inputElement = document.createElement('input');
8585
const inputProps = getInputProps({ inputElement });
@@ -91,19 +91,19 @@ describe('defaultSelectedItemId', () => {
9191
expect(onStateChange).toHaveBeenLastCalledWith({
9292
prevState: expect.anything(),
9393
state: expect.objectContaining({
94-
selectedItemId: 0,
94+
activeItemId: 0,
9595
}),
9696
});
9797
});
9898

99-
test('selects defaultSelectedItemId when ArrowDown on the last', () => {
99+
test('selects defaultActiveItemId when ArrowDown on the last', () => {
100100
const onStateChange = jest.fn();
101101
const { getInputProps } = createAutocomplete({
102102
openOnFocus: true,
103103
onStateChange,
104-
defaultSelectedItemId: 0,
104+
defaultActiveItemId: 0,
105105
initialState: {
106-
selectedItemId: 1,
106+
activeItemId: 1,
107107
},
108108
});
109109
const inputElement = document.createElement('input');
@@ -117,19 +117,19 @@ describe('defaultSelectedItemId', () => {
117117
expect(onStateChange).toHaveBeenLastCalledWith({
118118
prevState: expect.anything(),
119119
state: expect.objectContaining({
120-
selectedItemId: 0,
120+
activeItemId: 0,
121121
}),
122122
});
123123
});
124124

125-
test('selects defaultSelectedItemId when ArrowUp on the first', () => {
125+
test('selects defaultActiveItemId when ArrowUp on the first', () => {
126126
const onStateChange = jest.fn();
127127
const { getInputProps } = createAutocomplete({
128128
openOnFocus: true,
129129
onStateChange,
130-
defaultSelectedItemId: 0,
130+
defaultActiveItemId: 0,
131131
initialState: {
132-
selectedItemId: 1,
132+
activeItemId: 1,
133133
},
134134
});
135135
const inputElement = document.createElement('input');
@@ -143,7 +143,7 @@ describe('defaultSelectedItemId', () => {
143143
expect(onStateChange).toHaveBeenLastCalledWith({
144144
prevState: expect.anything(),
145145
state: expect.objectContaining({
146-
selectedItemId: 0,
146+
activeItemId: 0,
147147
}),
148148
});
149149
});

‎packages/autocomplete-core/src/__tests__/getFormProps.test.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,14 @@ describe('getFormProps', () => {
128128
});
129129
});
130130

131-
test('sets the selectedItemId to null', () => {
131+
test('sets the activeItemId to null', () => {
132132
const onStateChange = jest.fn();
133133
const { getFormProps, inputElement } = createPlayground(
134134
createAutocomplete,
135135
{
136136
onStateChange,
137137
initialState: {
138-
selectedItemId: 0,
138+
activeItemId: 0,
139139
},
140140
}
141141
);
@@ -146,7 +146,7 @@ describe('getFormProps', () => {
146146
expect(onStateChange).toHaveBeenLastCalledWith({
147147
prevState: expect.anything(),
148148
state: expect.objectContaining({
149-
selectedItemId: null,
149+
activeItemId: null,
150150
}),
151151
});
152152
});
@@ -264,14 +264,14 @@ describe('getFormProps', () => {
264264
});
265265
});
266266

267-
test('sets the selectedItemId to null without openOnFocus', () => {
267+
test('sets the activeItemId to null without openOnFocus', () => {
268268
const onStateChange = jest.fn();
269269
const { getFormProps, inputElement } = createPlayground(
270270
createAutocomplete,
271271
{
272272
onStateChange,
273273
initialState: {
274-
selectedItemId: 0,
274+
activeItemId: 0,
275275
},
276276
}
277277
);
@@ -282,21 +282,21 @@ describe('getFormProps', () => {
282282
expect(onStateChange).toHaveBeenLastCalledWith({
283283
prevState: expect.anything(),
284284
state: expect.objectContaining({
285-
selectedItemId: null,
285+
activeItemId: null,
286286
}),
287287
});
288288
});
289289

290-
test('sets the selectedItemId to defaultSelectedItemId with openOnFocus', () => {
290+
test('sets the activeItemId to defaultActiveItemId with openOnFocus', () => {
291291
const onStateChange = jest.fn();
292292
const { getFormProps, inputElement } = createPlayground(
293293
createAutocomplete,
294294
{
295-
defaultSelectedItemId: 0,
295+
defaultActiveItemId: 0,
296296
openOnFocus: true,
297297
onStateChange,
298298
initialState: {
299-
selectedItemId: null,
299+
activeItemId: null,
300300
},
301301
}
302302
);
@@ -307,7 +307,7 @@ describe('getFormProps', () => {
307307
expect(onStateChange).toHaveBeenLastCalledWith({
308308
prevState: expect.anything(),
309309
state: expect.objectContaining({
310-
selectedItemId: 0,
310+
activeItemId: 0,
311311
}),
312312
});
313313
});

0 commit comments

Comments
 (0)