feat(js): don't append panel on initial loading

francoischalifour · francoischalifour · commit 84ce729d24b7 · 2020-12-02T19:21:50.000+01:00
diff --git a/packages/autocomplete-js/src/render.ts b/packages/autocomplete-js/src/render.ts
@@ -59,7 +59,9 @@ export function render<TItem extends BaseItem>(
     return () => {};
   }
 
-  if (!panelRoot.contains(panel)) {
+  // We add the panel element to the DOM when it's not yet appended and that the
+  // items are fetched.
+  if (!panelRoot.contains(panel) && state.status !== 'loading') {
     panelRoot.appendChild(panel);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ export function render<TItem extends BaseItem>(`
`59`	`59`	`return () => {};`
`60`	`60`	`}`
`61`	`61`
`62`		`- if (!panelRoot.contains(panel)) {`
	`62`	`+ // We add the panel element to the DOM when it's not yet appended and that the`
	`63`	`+ // items are fetched.`
	`64`	`+ if (!panelRoot.contains(panel) && state.status !== 'loading') {`
`63`	`65`	`panelRoot.appendChild(panel);`
`64`	`66`	`}`
`65`	`67`