Skip to content

Commit 8a4da02

Browse files
refactor(js): rename getPanelPlacementStyle function
1 parent fdb8c22 commit 8a4da02

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

packages/autocomplete-js/src/autocomplete.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { createAutocompleteDom } from './createAutocompleteDom';
1313
import { createEffectWrapper } from './createEffectWrapper';
1414
import { createReactiveWrapper } from './createReactiveWrapper';
1515
import { getDefaultOptions } from './getDefaultOptions';
16-
import { getPanelPositionStyle } from './getPanelPositionStyle';
16+
import { getPanelPlacementStyle } from './getPanelPlacementStyle';
1717
import { renderPanel, renderSearchBox } from './render';
1818
import {
1919
AutocompleteApi,
@@ -116,7 +116,7 @@ export function autocomplete<TItem extends BaseItem>(
116116
setProperties(dom.value.panel, {
117117
style: isTouch.value
118118
? {}
119-
: getPanelPositionStyle({
119+
: getPanelPlacementStyle({
120120
panelPlacement: props.value.renderer.panelPlacement,
121121
container: dom.value.root,
122122
form: dom.value.form,

packages/autocomplete-js/src/getPanelPositionStyle.ts renamed to packages/autocomplete-js/src/getPanelPlacementStyle.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
import { AutocompleteOptions } from './types';
22

3-
type GetPanelPositionStyleParams = Pick<
3+
type GetPanelPlacementStyleParams = Pick<
44
AutocompleteOptions<any>,
55
'panelPlacement' | 'environment'
66
> & {
77
container: HTMLElement;
88
form: HTMLElement;
99
};
1010

11-
export function getPanelPositionStyle({
11+
export function getPanelPlacementStyle({
1212
panelPlacement,
1313
container,
1414
form,
1515
environment = window,
16-
}: GetPanelPositionStyleParams) {
16+
}: GetPanelPlacementStyleParams) {
1717
const containerRect = container.getBoundingClientRect();
1818
const top = container.offsetTop + containerRect.height;
1919

@@ -60,7 +60,9 @@ export function getPanelPositionStyle({
6060

6161
default: {
6262
throw new Error(
63-
`The \`panelPlacement\` value "${panelPlacement}" is not valid.`
63+
`The \`panelPlacement\` value ${JSON.stringify(
64+
panelPlacement
65+
)} is not valid.`
6466
);
6567
}
6668
}

0 commit comments

Comments
 (0)