refactor(core): don't use query.length

This can error if users return `undefined` instead of an empty string.

Author: francoischalifour

packages/autocomplete-core/src/getPropGetters.ts

@@ -135,7 +135,7 @@ export function getPropGetters<
     function onFocus(event: TEvent) {
       // We want to trigger a query when `openOnFocus` is true
       // because the panel should open with the current query.
-      if (props.openOnFocus || store.getState().query.length > 0) {
+      if (props.openOnFocus || store.getState().query) {
         onInput({
           event,
           props,

packages/autocomplete-core/src/onInput.ts

@@ -62,7 +62,7 @@ export function onInput<TItem extends BaseItem>({
   setQuery(query);
   setActiveItemId(props.defaultActiveItemId);
 
-  if (query.length === 0 && props.openOnFocus === false) {
+  if (query && props.openOnFocus === false) {
     setStatus('idle');
     setCollections(
       store.getState().collections.map((collection) => ({
@@ -120,7 +120,7 @@ export function onInput<TItem extends BaseItem>({
           setCollections(collections as any);
           setIsOpen(
             nextState.isOpen ??
-              ((query.length === 0 && props.openOnFocus) ||
+              ((query && props.openOnFocus) ||
                 props.shouldPanelShow({ state: store.getState() }))
           );
 

packages/autocomplete-core/src/stateReducer.ts

@@ -133,7 +133,7 @@ export const stateReducer: Reducer = (state, action) => {
       return {
         ...state,
         activeItemId: action.props.defaultActiveItemId,
-        isOpen: action.props.openOnFocus || state.query.length > 0,
+        isOpen: action.props.openOnFocus || state.query,
       };
     }