fix: apply options correctly for indices config import

Author: kai687

pkg/cmd/indices/config/import/import.go

@@ -55,20 +55,33 @@ func NewImportCmd(f *cmdutil.Factory) *cobra.Command {
 
 			if !confirm {
 				if !opts.IO.CanPrompt() {
-					return cmdutil.FlagErrorf("--confirm required when non-interactive shell is detected")
+					return cmdutil.FlagErrorf(
+						"--confirm required when non-interactive shell is detected",
+					)
 				}
 				opts.DoConfirm = true
 			}
 
 			// JSON is parsed, read, validated (and options asked if interactive mode)
-			err := handler.HandleFlags(&handler.IndexConfigImportHandler{Opts: opts}, opts.IO.CanPrompt())
+			err := handler.HandleFlags(
+				&handler.IndexConfigImportHandler{Opts: opts},
+				opts.IO.CanPrompt(),
+			)
 			if err != nil {
 				return err
 			}
 
 			if opts.DoConfirm {
 				var confirmed bool
-				fmt.Printf("\n%s", GetConfirmMessage(cs, opts.Scope, opts.ClearExistingRules, opts.ClearExistingSynonyms))
+				fmt.Printf(
+					"\n%s",
+					GetConfirmMessage(
+						cs,
+						opts.Scope,
+						opts.ClearExistingRules,
+						opts.ClearExistingSynonyms,
+					),
+				)
 				err = prompt.Confirm("Import config?", &confirmed)
 				if err != nil {
 					return fmt.Errorf("failed to prompt: %w", err)
@@ -85,20 +98,27 @@ func NewImportCmd(f *cmdutil.Factory) *cobra.Command {
 	// Common
 	cmd.Flags().BoolVarP(&confirm, "confirm", "y", false, "Skip confirmation prompt")
 	// Options
-	cmd.Flags().StringVarP(&opts.FilePath, "file", "F", "", "Directory path of the JSON config file")
-	cmd.Flags().StringSliceVarP(&opts.Scope, "scope", "s", []string{}, "Scope to import (default: none)")
+	cmd.Flags().
+		StringVarP(&opts.FilePath, "file", "F", "", "Directory path of the JSON config file")
+	cmd.Flags().
+		StringSliceVarP(&opts.Scope, "scope", "s", []string{}, "Scope to import (default: none)")
 	_ = cmd.RegisterFlagCompletionFunc("scope",
 		cmdutil.StringSliceCompletionFunc(map[string]string{
 			"settings": "settings",
 			"synonyms": "synonyms",
 			"rules":    "rules",
 		}, "import only"))
-	cmd.Flags().BoolVarP(&opts.ClearExistingSynonyms, "clear-existing-synonyms", "o", false, fmt.Sprintf("Clear %s existing synonyms of the index before import", cs.Bold("ALL")))
-	cmd.Flags().BoolVarP(&opts.ClearExistingRules, "clear-existing-rules", "r", false, fmt.Sprintf("Clear %s existing rules of the index before import", cs.Bold("ALL")))
+	cmd.Flags().
+		BoolVarP(&opts.ClearExistingSynonyms, "clear-existing-synonyms", "o", false, fmt.Sprintf("Clear %s existing synonyms of the index before import", cs.Bold("ALL")))
+	cmd.Flags().
+		BoolVarP(&opts.ClearExistingRules, "clear-existing-rules", "r", false, fmt.Sprintf("Clear %s existing rules of the index before import", cs.Bold("ALL")))
 	// Replicas
-	cmd.Flags().BoolVarP(&opts.ForwardSynonymsToReplicas, "forward-synonyms-to-replicas", "m", false, "Forward imported synonyms to replicas")
-	cmd.Flags().BoolVarP(&opts.ForwardRulesToReplicas, "forward-rules-to-replicas", "l", false, "Forward imported rules to replicas")
-	cmd.Flags().BoolVarP(&opts.ForwardSettingsToReplicas, "forward-settings-to-replicas", "t", false, "Forward imported settings to replicas")
+	cmd.Flags().
+		BoolVarP(&opts.ForwardSynonymsToReplicas, "forward-synonyms-to-replicas", "m", false, "Forward imported synonyms to replicas")
+	cmd.Flags().
+		BoolVarP(&opts.ForwardRulesToReplicas, "forward-rules-to-replicas", "l", false, "Forward imported rules to replicas")
+	cmd.Flags().
+		BoolVarP(&opts.ForwardSettingsToReplicas, "forward-settings-to-replicas", "t", false, "Forward imported settings to replicas")
 
 	return cmd
 }
@@ -110,35 +130,49 @@ func runImportCmd(opts *config.ImportOptions) error {
 		return err
 	}
 
-	indice := client.InitIndex(opts.Indice)
+	index := client.InitIndex(opts.Indice)
 
 	if opts.ImportConfig.Settings != nil && utils.Contains(opts.Scope, "settings") {
-		_, err = indice.SetSettings(*opts.ImportConfig.Settings, opt.ForwardToReplicas(opts.ForwardSettingsToReplicas))
+		_, err = index.SetSettings(
+			*opts.ImportConfig.Settings,
+			opt.ForwardToReplicas(opts.ForwardSettingsToReplicas),
+		)
 		if err != nil {
-			return fmt.Errorf("%s An error occurred when saving settings: %w", cs.FailureIcon(), err)
+			return fmt.Errorf(
+				"%s An error occurred when saving settings: %w",
+				cs.FailureIcon(),
+				err,
+			)
 		}
 	}
 	if len(opts.ImportConfig.Synonyms) > 0 && utils.Contains(opts.Scope, "synonyms") {
 		synonyms, err := SynonymsToSearchSynonyms(opts.ImportConfig.Synonyms)
 		if err != nil {
 			return err
 		}
-		_, err = indice.SaveSynonyms(synonyms,
-			[]interface{}{
-				opt.ForwardToReplicas(opts.ForwardSynonymsToReplicas),
-				opt.ReplaceExistingSynonyms(opts.ClearExistingSynonyms),
-			},
+		if opts.ClearExistingSynonyms {
+			fmt.Println("DEBUG: clearing existing synonyms...")
+		}
+
+		_, err = index.SaveSynonyms(
+			synonyms,
+			opt.ForwardToReplicas(opts.ForwardSynonymsToReplicas),
+			opt.ReplaceExistingSynonyms(opts.ClearExistingSynonyms),
 		)
 		if err != nil {
-			return fmt.Errorf("%s An error occurred when saving synonyms: %w", cs.FailureIcon(), err)
+			return fmt.Errorf(
+				"%s An error occurred when saving synonyms: %w",
+				cs.FailureIcon(),
+				err,
+			)
 		}
 	}
 	if len(opts.ImportConfig.Rules) > 0 && utils.Contains(opts.Scope, "rules") {
-		_, err = indice.SaveRules(opts.ImportConfig.Rules,
-			[]interface{}{
-				opt.ForwardToReplicas(opts.ForwardRulesToReplicas),
-				opt.ClearExistingRules(opts.ClearExistingRules),
-			})
+		_, err = index.SaveRules(
+			opts.ImportConfig.Rules,
+			opt.ForwardToReplicas(opts.ForwardRulesToReplicas),
+			opt.ClearExistingRules(opts.ClearExistingRules),
+		)
 		if err != nil {
 			return fmt.Errorf("%s An error occurred when saving rules: %w", cs.FailureIcon(), err)
 		}