Skip to content

chore: fix version in metadata and ship config#68

Merged
JasonBerry merged 1 commit intomasterfrom
fix-metadata-version
Mar 17, 2026
Merged

chore: fix version in metadata and ship config#68
JasonBerry merged 1 commit intomasterfrom
fix-metadata-version

Conversation

@JasonBerry
Copy link
Collaborator

@JasonBerry JasonBerry commented Mar 16, 2026

Changes

  • ship.config.js: Read version from package.json instead of using Ship.js's tag parameter (which is the npm dist-tag "latest", not the semver version)
  • ship.config.js: Remove unwanted shouldPrepare block
  • metadata.yaml: Fix 5 historical entries that had "latest" instead of actual version numbers, and remove v prefix for consistency

@JasonBerry JasonBerry requested a review from a team as a code owner March 16, 2026 05:48
Copy link
Contributor

@jkaho jkaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you enlighten me as to why you say shouldPrepare is unused? I thought this config is used to block releases for chore and refactor commits, for example. At least that's what I got from looking at the shipjs source code.

@JasonBerry
Copy link
Collaborator Author

JasonBerry commented Mar 16, 2026

Can you enlighten me as to why you say shouldPrepare is unused? I thought this config is used to block releases for chore and refactor commits, for example. At least that's what I got from looking at the shipjs source code.

"Unused" is the wrong word to use there, "unwanted" would be more accurate. Any time search-insights is updated we'd want to be able to release a change, but that's typically a "chore" commit and the shouldPrepare was blocking us from being able to trigger a release after updating that package.

@JasonBerry JasonBerry requested a review from jkaho March 16, 2026 06:38
Copy link
Contributor

@jkaho jkaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got this script that runs a weekly release–wouldn't this change mean that refactors would also result in a release? Is this what we want? Could we skip preparation for just the refactors?

@JasonBerry
Copy link
Collaborator Author

We've got this script that runs a weekly release–wouldn't this change mean that refactors would also result in a release? Is this what we want? Could we skip preparation for just the refactors?

That script doesn't automatically release, it just creates a PR which you can choose to merge if you want to trigger the release, so we still have full control of when we want to release.

Copy link
Contributor

@jkaho jkaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, thanks for clearing that up 👍

@JasonBerry JasonBerry merged commit 65ad596 into master Mar 17, 2026
3 checks passed
@JasonBerry JasonBerry deleted the fix-metadata-version branch March 17, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants